aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorNIIBE Yutaka <[email protected]>2020-05-20 03:03:07 +0000
committerNIIBE Yutaka <[email protected]>2020-05-20 03:03:07 +0000
commitcea6925fa43cacbfd3c20a685740d634b1306aed (patch)
tree94335eb965cc0cea3c14fa6147f4a4512911daba
parentagent: Don't use gcry_mpi_scan when not needed. (diff)
downloadgnupg-cea6925fa43cacbfd3c20a685740d634b1306aed.tar.gz
gnupg-cea6925fa43cacbfd3c20a685740d634b1306aed.zip
ecc-sos: Fix ECDH.
* g10/ecdh.c (pk_ecdh_encrypt_with_shared_point): Fix deallocation. Signed-off-by: NIIBE Yutaka <[email protected]>
-rw-r--r--g10/ecdh.c10
1 files changed, 2 insertions, 8 deletions
diff --git a/g10/ecdh.c b/g10/ecdh.c
index f8080a76a..b4d93be7d 100644
--- a/g10/ecdh.c
+++ b/g10/ecdh.c
@@ -133,10 +133,7 @@ pk_ecdh_encrypt_with_shared_point (int is_encrypt, gcry_mpi_t shared_mpi,
returns X with no prefix of 40, so, nbytes == secret_x_size
is allowed. */
if (nbytes < secret_x_size)
- {
- xfree (secret_x);
- return gpg_error (GPG_ERR_BAD_DATA);
- }
+ return gpg_error (GPG_ERR_BAD_DATA);
/* Remove the prefix. */
if ((nbytes & 1))
@@ -159,10 +156,7 @@ pk_ecdh_encrypt_with_shared_point (int is_encrypt, gcry_mpi_t shared_mpi,
* a KEK.
*/
if (!gcry_mpi_get_flag (pkey[2], GCRYMPI_FLAG_OPAQUE))
- {
- xfree (secret_x);
- return gpg_error (GPG_ERR_BUG);
- }
+ return gpg_error (GPG_ERR_BUG);
kek_params = gcry_mpi_get_opaque (pkey[2], &nbits);
kek_params_size = (nbits+7)/8;