diff options
| author | Werner Koch <[email protected]> | 2017-03-30 08:35:20 +0000 |
|---|---|---|
| committer | Werner Koch <[email protected]> | 2017-03-30 08:54:10 +0000 |
| commit | bb61191aad98c3dbb487c1f76dd1552d44a52fe3 (patch) | |
| tree | 5d7d142d18773697ad3b2980d8b94e7c3ea519d6 | |
| parent | spelling: Correct achived to achieved. (diff) | |
| download | gnupg-bb61191aad98c3dbb487c1f76dd1552d44a52fe3.tar.gz gnupg-bb61191aad98c3dbb487c1f76dd1552d44a52fe3.zip | |
gpg: Fix exporting of zero length user ID packets.
* g10/build-packet.c (do_user_id): Avoid indeterminate length header.
--
We are able to import such user ids but when exporting them the
exported data could not be imported again because the parser bails out
on invalid keyrings. This is now fixed and should be backported.
Note that in 1.4 and 2.0 this is only an issue for attribute packets.
In 2.1 user IDs were also affected.a
Signed-off-by: Werner Koch <[email protected]>
| -rw-r--r-- | g10/build-packet.c | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/g10/build-packet.c b/g10/build-packet.c index 028d064a0..2e9dfa4b6 100644 --- a/g10/build-packet.c +++ b/g10/build-packet.c @@ -204,7 +204,12 @@ do_user_id( IOBUF out, int ctb, PKT_user_id *uid ) { if( uid->attrib_data ) { - write_header(out, ctb, uid->attrib_len); + /* We need to take special care of a user ID with a length of 0: + * Without forcing HDRLEN to 2 in this case an indeterminate length + * packet would be written which is not allowed. Note that we are + * always called with a CTB indicating an old packet header format, + * so that forcing a 2 octet header works. */ + write_header2(out, ctb, uid->attrib_len, (uid->attrib_len? 0 : 2)); if( iobuf_write( out, uid->attrib_data, uid->attrib_len ) ) return G10ERR_WRITE_FILE; } |