GpgFrontend/vmime
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Avoid extern "C" blocks around ICU includes

Browse Source 
Looks like it's not necessary, and, moreover, I'm getting this with recent ICU (64.2):
```
/usr/include/unicode/localpointer.h:67:1: error: template with C linkage
   67 | template<typename T>
      | ^~~~~~~~
/var/tmp/portage/dev-libs/vmime-9999/work/vmime-9999/src/vmime/charsetConverter_icu.cpp:37:1: note: ‘extern "C"’ linkage started here
   37 | extern "C" {
      | ^~~~~~~~~~
```

(there's also an issue about that, #218)
This commit is contained in:
0xd34df00d 2019-09-22 08:26:11 -04:00 committed by GitHub
parent 182e8f5dd8
commit e96aeeb14d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 0 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/vmime/charsetConverter_icu.cpp
View File

@ -34,15 +34,12 @@
#include "vmime/utility/outputStreamStringAdapter.hpp" #include "vmime/utility/outputStreamStringAdapter.hpp"
extern "C" {
#ifndef VMIME_BUILDING_DOC #ifndef VMIME_BUILDING_DOC
#include <unicode/ucnv.h> #include <unicode/ucnv.h>
#include <unicode/ucnv_err.h> #include <unicode/ucnv_err.h>
#endif // VMIME_BUILDING_DOC #endif // VMIME_BUILDING_DOC
}
#include <unicode/unistr.h> #include <unicode/unistr.h>