From 512c2198507bcfa4367e39163edf8b626a3008a9 Mon Sep 17 00:00:00 2001 From: saturneric Date: Mon, 5 Aug 2024 17:29:04 +0200 Subject: fix: remove mimalloc from source Too bad, under Flatpak or even under Windows, this library can cause the program to crash. The reason for this is that there are some places that do not override the memory allocation method, but this does not guarantee that the mimalloc library will be loaded first in some environments (especially Flatpak) so I think it would be better to let the user install it themselves rather than include this library. Then override all mallocs as needed, which is easy to do. Sacrificing some of the security of the default state for the stability of the program feels necessary to me. --- .github/workflows/codeql-analysis.yml | 8 -------- .github/workflows/release-qt5.yml | 20 -------------------- .github/workflows/release.yml | 20 -------------------- 3 files changed, 48 deletions(-) (limited to '.github') diff --git a/.github/workflows/codeql-analysis.yml b/.github/workflows/codeql-analysis.yml index b1a100eb..9b11ad8d 100644 --- a/.github/workflows/codeql-analysis.yml +++ b/.github/workflows/codeql-analysis.yml @@ -83,14 +83,6 @@ jobs: sudo make install cd ${{github.workspace}} - - name: Build mimalloc (Linux) - run: | - cd ${{github.workspace}}/third_party/mimalloc - mkdir build && cd build - cmake -G Ninja -DMI_SECURE=ON .. - ninja - sudo ninja install - - name: Build googletest (Linux) run: | cd ${{github.workspace}}/third_party/googletest diff --git a/.github/workflows/release-qt5.yml b/.github/workflows/release-qt5.yml index 1102379c..7870159e 100644 --- a/.github/workflows/release-qt5.yml +++ b/.github/workflows/release-qt5.yml @@ -138,26 +138,6 @@ jobs: cd ${{github.workspace}} if: matrix.os == 'ubuntu-20.04' - - name: Build mimalloc (Linux) - run: | - git clone --depth 1 --branch v2.1.7 https://github.com/microsoft/mimalloc.git ${{github.workspace}}/third_party/mimalloc - cd ${{github.workspace}}/third_party/mimalloc - mkdir build && cd build - cmake -G Ninja -DMI_SECURE=ON .. - ninja - sudo ninja install - if: matrix.os == 'ubuntu-20.04' - - - name: Build mimalloc (Windows) - shell: msys2 {0} - run: | - git clone --depth 1 --branch v2.1.7 https://github.com/microsoft/mimalloc.git ${{github.workspace}}/third_party/mimalloc - cd ${{github.workspace}}/third_party/mimalloc - mkdir build && cd build - cmake -G Ninja -DMI_SECURE=ON -DCMAKE_INSTALL_PREFIX=$MSYSTEM_PREFIX .. && ninja - ninja install - if: matrix.os == 'windows-2019' - - name: Build googletest (Linux) run: | git clone --depth 1 --branch v1.15.0 https://github.com/google/googletest.git ${{github.workspace}}/third_party/googletest diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 47bf1f5d..e6542d4d 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -164,26 +164,6 @@ jobs: make install if: matrix.os == 'windows-2019' - - name: Build mimalloc (Linux) - run: | - git clone --depth 1 --branch v2.1.7 https://github.com/microsoft/mimalloc.git ${{github.workspace}}/third_party/mimalloc - cd ${{github.workspace}}/third_party/mimalloc - mkdir build && cd build - cmake -G Ninja -DMI_SECURE=ON .. - ninja - sudo ninja install - if: matrix.os == 'ubuntu-20.04' - - - name: Build mimalloc (Windows) - shell: msys2 {0} - run: | - git clone --depth 1 --branch v2.1.7 https://github.com/microsoft/mimalloc.git ${{github.workspace}}/third_party/mimalloc - cd ${{github.workspace}}/third_party/mimalloc - mkdir build && cd build - cmake -G Ninja -DMI_SECURE=ON -DCMAKE_INSTALL_PREFIX=$MSYSTEM_PREFIX .. && ninja - ninja install - if: matrix.os == 'windows-2019' - - name: Build googletest (Linux) run: | git clone --depth 1 --branch v1.15.0 https://github.com/google/googletest.git ${{github.workspace}}/third_party/googletest -- cgit v1.2.3