From 766d42c248a8c526b831685e93d54db81492f5a8 Mon Sep 17 00:00:00 2001 From: Maximilian Krambach Date: Mon, 27 Aug 2018 12:32:28 +0200 Subject: js: typecheck destructured parameters -- * destructuring just takes the input argument and treats it as object. In cases like in src/Keyring/generateKey, where I forgot to change the old syntax, the fingerprint as string was destructured into an object without "pattern", which caused all Keys to be retrieved. So, methods with a destructuring now check if the first argument is an object and get a default empty object if no parameter is submitted. This allows the further use of destructured parameters, while still ensuring nothing vastly incorrect is used. * src/Kering.js, unittsets.js: fixed old syntax in method usage --- lang/js/unittests.js | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) (limited to 'lang/js/unittests.js') diff --git a/lang/js/unittests.js b/lang/js/unittests.js index 8f1ffb66..de06320e 100644 --- a/lang/js/unittests.js +++ b/lang/js/unittests.js @@ -287,13 +287,14 @@ function unittests (){ it('Querying non-existing Key from Keyring', function (done){ let keyring = new GPGME_Keyring; - keyring.getKeys(kp.invalidKeyFingerprint, true).then( - function (result){ - expect(result).to.be.an('array'); - expect(result.length).to.equal(0); - done(); - } - ); + keyring.getKeys({ + pattern: kp.invalidKeyFingerprint, + prepare_sync: true + }).then(function (result){ + expect(result).to.be.an('array'); + expect(result.length).to.equal(0); + done(); + }); }); }); -- cgit v1.2.3