GpgFrontend/gpgme
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

gpg: Avoid error diagnostics with --override-session-key when verifying

Browse Source 
* src/engine-gpg.c (gpg_decrypt): only send --no-keyring when we are
not verifying.

--

Without this change, the signature verification would fail.  This
problem was introduced in bded8ebc59 in
an attempt to avoid an error when *not* verifying.  Clearly more test
suite coverage is needed to avoid introducing this sort of problem in
the future.

GnuPG-bug-id: 3464
Signed-off-by: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
This commit is contained in:
Daniel Kahn Gillmor 2019-05-29 17:56:01 -04:00
parent f9c923bb2d
commit fa0a5ffd49
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/engine-gpg.c
View File

@ -1695,11 +1695,14 @@ gpg_decrypt (void *engine,
strlen (override_session_key), 1); strlen (override_session_key), 1);
if (!err) if (!err)
{ {
/* We add --no-keyring because a keyring is not required /* When we are not trying to verify signatures as well,
* when we are overriding the session key. It would * we add --no-keyring because a keyring is not required
* for decryption when overriding the session key. It would
* work without that option but --no-keyring avoids that * work without that option but --no-keyring avoids that
* gpg return a failure due to a missing key log_error() * gpg return a failure due to a missing key log_error()
* diagnostic. --no-keyring is supported since 2.1.14. */ * diagnostic. --no-keyring is supported since 2.1.14. */
if (!(flags & GPGME_DECRYPT_VERIFY))
err = add_arg (gpg, "--no-keyring"); err = add_arg (gpg, "--no-keyring");
if (!err) if (!err)
err = add_arg (gpg, "--override-session-key-fd"); err = add_arg (gpg, "--override-session-key-fd");