From eae9c32bd9c80ca4a4ecf794808211808f2ebbdd Mon Sep 17 00:00:00 2001 From: Werner Koch Date: Mon, 19 Aug 2013 20:38:36 +0200 Subject: [PATCH] tests: Fix NULL ptr deref in gpgsm/t-verify. * tests/gpgsm/t-verify.c (check_result): Do not dereference a sig or sig->fpr if NULL. --- tests/gpgsm/t-verify.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/gpgsm/t-verify.c b/tests/gpgsm/t-verify.c index a26617e0..901b46fb 100644 --- a/tests/gpgsm/t-verify.c +++ b/tests/gpgsm/t-verify.c @@ -63,6 +63,8 @@ check_result (gpgme_verify_result_t result, int summary, char *fpr, fprintf (stderr, "%s:%i: Unexpected number of signatures\n", __FILE__, __LINE__); got_errors = 1; + if (!sig) + return; } if (sig->summary != summary) { @@ -71,7 +73,7 @@ check_result (gpgme_verify_result_t result, int summary, char *fpr, __FILE__, __LINE__, summary, sig->summary); got_errors = 1; } - if (strcmp (sig->fpr, fpr)) + if (sig->fpr && strcmp (sig->fpr, fpr)) { fprintf (stderr, "%s:%i: Unexpected fingerprint: %s\n", __FILE__, __LINE__, sig->fpr);