GpgFrontend/gpgme
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

qt: Remove left-over mentions of showErrorDialog

Browse Source 
* lang/qt/src/qgpgmedecryptjob.cpp,
lang/qt/src/qgpgmeimportfromkeyserverjob.cpp,
lang/qt/src/qgpgmeimportjob.cpp: Remove obsolete comment.
* lang/qt/src/qgpgmekeylistjob.cpp,
lang/qt/src/qgpgmelistallkeysjob.cpp: Remove long obsolete, #if 0'ed out
definitions of showErrorDialog.
--

Informing the users about errors is the responsibility of the users of
the QGpgME Job API since a long time.
This commit is contained in:
Ingo Klöcker 2024-01-19 15:11:01 +01:00
parent cc1f2b5acb
commit eae22d9a48
No known key found for this signature in database
GPG Key ID: F5A5D1692277A1E9
5 changed files with 1 additions and 32 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lang/qt/src/qgpgmedecryptjob.cpp
View File

@ -126,8 +126,6 @@ GpgME::DecryptionResult QGpgME::QGpgMEDecryptJob::exec(const QByteArray &cipherT
return mResult; return mResult;
} }
//PENDING(marc) implement showErrorDialog()
void QGpgMEDecryptJob::resultHook(const result_type &tuple) void QGpgMEDecryptJob::resultHook(const result_type &tuple)
{ {
mResult = std::get<0>(tuple); mResult = std::get<0>(tuple);

2
lang/qt/src/qgpgmeimportfromkeyserverjob.cpp
View File

@ -78,8 +78,6 @@ GpgME::ImportResult QGpgME::QGpgMEImportFromKeyserverJob::exec(const std::vector
return mResult; return mResult;
} }
// PENDING(marc) implement showErrorDialog()
void QGpgME::QGpgMEImportFromKeyserverJob::resultHook(const result_type &tuple) void QGpgME::QGpgMEImportFromKeyserverJob::resultHook(const result_type &tuple)
{ {
mResult = std::get<0>(tuple); mResult = std::get<0>(tuple);

2
lang/qt/src/qgpgmeimportjob.cpp
View File

@ -166,8 +166,6 @@ Error QGpgMEImportJob::startLater(const QByteArray &certData)
return {}; return {};
} }
// PENDING(marc) implement showErrorDialog()
void QGpgME::QGpgMEImportJob::resultHook(const result_type &tuple) void QGpgME::QGpgMEImportJob::resultHook(const result_type &tuple)
{ {
mResult = std::get<0>(tuple); mResult = std::get<0>(tuple);

14
lang/qt/src/qgpgmekeylistjob.cpp
View File

@ -161,17 +161,5 @@ void QGpgMEKeyListJob::addMode(KeyListMode mode)
{ {
context()->addKeyListMode(mode); context()->addKeyListMode(mode);
} }
#if 0
void QGpgMEKeyListJob::showErrorDialog(QWidget *parent, const QString &caption) const
{
if (!mResult.error() || mResult.error().isCanceled()) {
return;
}
const QString msg = i18n("<qt><p>An error occurred while fetching "
"the keys from the backend:</p>"
"<p><b>%1</b></p></qt>",
QString::fromLocal8Bit(mResult.error().asString()));
KMessageBox::error(parent, msg, caption);
}
#endif
#include "qgpgmekeylistjob.moc" #include "qgpgmekeylistjob.moc"

13
lang/qt/src/qgpgmelistallkeysjob.cpp
View File

@ -245,17 +245,4 @@ void QGpgMEListAllKeysJob::resultHook(const result_type &tuple)
mResult = std::get<0>(tuple); mResult = std::get<0>(tuple);
} }
#if 0
void QGpgMEListAllKeysJob::showErrorDialog(QWidget *parent, const QString &caption) const
{
if (!mResult.error() || mResult.error().isCanceled()) {
return;
}
const QString msg = i18n("<qt><p>An error occurred while fetching "
"the keys from the backend:</p>"
"<p><b>%1</b></p></qt>",
QString::fromLocal8Bit(mResult.error().asString()));
KMessageBox::error(parent, msg, caption);
}
#endif
#include "qgpgmelistallkeysjob.moc" #include "qgpgmelistallkeysjob.moc"