qt: Allow setting the file name of encrypted data

* lang/qt/src/Makefile.am (qgpgme_sources): Add encryptjob.cpp.
* lang/qt/src/encryptjob.cpp: New.
* lang/qt/src/encryptjob.h (class EncryptJob): Add member functions
setFileName, fileName.
* lang/qt/src/qgpgmeencryptjob.cpp (encrypt): Set file name of input.
(encrypt_qba, QGpgMEEncryptJob::exec, QGpgMEEncryptJob::start): Pass
file name to encrypt resp. encrypt_qba.
--

This makes it possible to store the original name of an encrypted file
in the encryption result.

GnuPG-bug-id: 6056
This commit is contained in:
Ingo Klöcker 2022-07-05 18:02:20 +02:00
parent 31423945d2
commit bc10169724
4 changed files with 84 additions and 9 deletions

View File

@ -44,7 +44,7 @@ qgpgme_sources = \
qgpgmekeyformailboxjob.cpp qgpgme_debug.cpp \ qgpgmekeyformailboxjob.cpp qgpgme_debug.cpp \
qgpgmetofupolicyjob.cpp qgpgmequickjob.cpp \ qgpgmetofupolicyjob.cpp qgpgmequickjob.cpp \
defaultkeygenerationjob.cpp qgpgmewkspublishjob.cpp \ defaultkeygenerationjob.cpp qgpgmewkspublishjob.cpp \
qgpgmegpgcardjob.cpp changeexpiryjob.cpp importjob.cpp \ qgpgmegpgcardjob.cpp changeexpiryjob.cpp encryptjob.cpp importjob.cpp \
dn.cpp cryptoconfig.cpp wkdlookupresult.cpp \ dn.cpp cryptoconfig.cpp wkdlookupresult.cpp \
util.cpp util.cpp

View File

@ -0,0 +1,61 @@
/*
encryptjob.cpp
This file is part of qgpgme, the Qt API binding for gpgme
Copyright (c) 2022 g10 Code GmbH
Software engineering by Ingo Klöcker <dev@ingo-kloecker.de>
QGpgME is free software; you can redistribute it and/or
modify it under the terms of the GNU General Public License as
published by the Free Software Foundation; either version 2 of the
License, or (at your option) any later version.
QGpgME is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
General Public License for more details.
You should have received a copy of the GNU General Public License
along with this program; if not, write to the Free Software
Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
In addition, as a special exception, the copyright holders give
permission to link the code of this program with any edition of
the Qt library by Trolltech AS, Norway (or with modified versions
of Qt that use the same license as Qt), and distribute linked
combinations including the two. You must obey the GNU General
Public License in all respects for all of the code used other than
Qt. If you modify this file, you may extend this exception to
your version of the file, but you are not obligated to do so. If
you do not wish to do so, delete this exception statement from
your version.
*/
#ifdef HAVE_CONFIG_H
#include "config.h"
#endif
#include "encryptjob.h"
#include "job_p.h"
using namespace QGpgME;
namespace
{
struct EncryptJobPrivate : public JobPrivate
{
QString m_fileName;
};
}
void EncryptJob::setFileName(const QString &fileName)
{
auto d = jobPrivate<EncryptJobPrivate>(this);
d->m_fileName = fileName;
}
QString EncryptJob::fileName() const
{
auto d = jobPrivate<EncryptJobPrivate>(this);
return d->m_fileName;
}

View File

@ -5,6 +5,8 @@
Copyright (c) 2004, 2007 Klarälvdalens Datakonsult AB Copyright (c) 2004, 2007 Klarälvdalens Datakonsult AB
Copyright (c) 2016 by Bundesamt für Sicherheit in der Informationstechnik Copyright (c) 2016 by Bundesamt für Sicherheit in der Informationstechnik
Software engineering by Intevation GmbH Software engineering by Intevation GmbH
Copyright (c) 2022 g10 Code GmbH
Software engineering by Ingo Klöcker <dev@ingo-kloecker.de>
QGpgME is free software; you can redistribute it and/or QGpgME is free software; you can redistribute it and/or
modify it under the terms of the GNU General Public License as modify it under the terms of the GNU General Public License as
@ -80,6 +82,9 @@ protected:
public: public:
~EncryptJob(); ~EncryptJob();
void setFileName(const QString &fileName);
QString fileName() const;
/** /**
Starts the encryption operation. \a recipients is the a list of Starts the encryption operation. \a recipients is the a list of
keys to encrypt \a plainText to. Empty (null) keys are keys to encrypt \a plainText to. Empty (null) keys are

View File

@ -5,6 +5,8 @@
Copyright (c) 2004,2007,2008 Klarälvdalens Datakonsult AB Copyright (c) 2004,2007,2008 Klarälvdalens Datakonsult AB
Copyright (c) 2016 by Bundesamt für Sicherheit in der Informationstechnik Copyright (c) 2016 by Bundesamt für Sicherheit in der Informationstechnik
Software engineering by Intevation GmbH Software engineering by Intevation GmbH
Copyright (c) 2022 g10 Code GmbH
Software engineering by Ingo Klöcker <dev@ingo-kloecker.de>
QGpgME is free software; you can redistribute it and/or QGpgME is free software; you can redistribute it and/or
modify it under the terms of the GNU General Public License as modify it under the terms of the GNU General Public License as
@ -45,7 +47,7 @@
#include "data.h" #include "data.h"
#include <QBuffer> #include <QBuffer>
#include <QFileInfo>
#include <cassert> #include <cassert>
@ -71,7 +73,8 @@ static QGpgMEEncryptJob::result_type encrypt(Context *ctx, QThread *thread,
const std::weak_ptr<QIODevice> &plainText_, const std::weak_ptr<QIODevice> &plainText_,
const std::weak_ptr<QIODevice> &cipherText_, const std::weak_ptr<QIODevice> &cipherText_,
const Context::EncryptionFlags eflags, const Context::EncryptionFlags eflags,
bool outputIsBsse64Encoded) bool outputIsBsse64Encoded,
const QString &fileName)
{ {
const std::shared_ptr<QIODevice> plainText = plainText_.lock(); const std::shared_ptr<QIODevice> plainText = plainText_.lock();
@ -81,7 +84,12 @@ static QGpgMEEncryptJob::result_type encrypt(Context *ctx, QThread *thread,
const _detail::ToThreadMover ptMover(plainText, thread); const _detail::ToThreadMover ptMover(plainText, thread);
QGpgME::QIODeviceDataProvider in(plainText); QGpgME::QIODeviceDataProvider in(plainText);
const Data indata(&in); Data indata(&in);
const auto pureFileName = QFileInfo{fileName}.fileName().toStdString();
if (!pureFileName.empty()) {
indata.setFileName(pureFileName.c_str());
}
if (!cipherText) { if (!cipherText) {
QGpgME::QByteArrayDataProvider out; QGpgME::QByteArrayDataProvider out;
@ -111,20 +119,20 @@ static QGpgMEEncryptJob::result_type encrypt(Context *ctx, QThread *thread,
} }
static QGpgMEEncryptJob::result_type encrypt_qba(Context *ctx, const std::vector<Key> &recipients, const QByteArray &plainText, const Context::EncryptionFlags eflags, bool outputIsBsse64Encoded) static QGpgMEEncryptJob::result_type encrypt_qba(Context *ctx, const std::vector<Key> &recipients, const QByteArray &plainText, const Context::EncryptionFlags eflags, bool outputIsBsse64Encoded, const QString &fileName)
{ {
const std::shared_ptr<QBuffer> buffer(new QBuffer); const std::shared_ptr<QBuffer> buffer(new QBuffer);
buffer->setData(plainText); buffer->setData(plainText);
if (!buffer->open(QIODevice::ReadOnly)) { if (!buffer->open(QIODevice::ReadOnly)) {
assert(!"This should never happen: QBuffer::open() failed"); assert(!"This should never happen: QBuffer::open() failed");
} }
return encrypt(ctx, nullptr, recipients, buffer, std::shared_ptr<QIODevice>(), eflags, outputIsBsse64Encoded); return encrypt(ctx, nullptr, recipients, buffer, std::shared_ptr<QIODevice>(), eflags, outputIsBsse64Encoded, fileName);
} }
Error QGpgMEEncryptJob::start(const std::vector<Key> &recipients, const QByteArray &plainText, bool alwaysTrust) Error QGpgMEEncryptJob::start(const std::vector<Key> &recipients, const QByteArray &plainText, bool alwaysTrust)
{ {
run(std::bind(&encrypt_qba, std::placeholders::_1, recipients, plainText, run(std::bind(&encrypt_qba, std::placeholders::_1, recipients, plainText,
alwaysTrust ? Context::AlwaysTrust : Context::None, mOutputIsBase64Encoded)); alwaysTrust ? Context::AlwaysTrust : Context::None, mOutputIsBase64Encoded, fileName()));
return Error(); return Error();
} }
@ -136,14 +144,15 @@ void QGpgMEEncryptJob::start(const std::vector<Key> &recipients, const std::shar
recipients, recipients,
std::placeholders::_3, std::placeholders::_4, std::placeholders::_3, std::placeholders::_4,
eflags, eflags,
mOutputIsBase64Encoded), mOutputIsBase64Encoded,
fileName()),
plainText, cipherText); plainText, cipherText);
} }
EncryptionResult QGpgMEEncryptJob::exec(const std::vector<Key> &recipients, const QByteArray &plainText, EncryptionResult QGpgMEEncryptJob::exec(const std::vector<Key> &recipients, const QByteArray &plainText,
const Context::EncryptionFlags eflags, QByteArray &cipherText) const Context::EncryptionFlags eflags, QByteArray &cipherText)
{ {
const result_type r = encrypt_qba(context(), recipients, plainText, eflags, mOutputIsBase64Encoded); const result_type r = encrypt_qba(context(), recipients, plainText, eflags, mOutputIsBase64Encoded, fileName());
cipherText = std::get<1>(r); cipherText = std::get<1>(r);
resultHook(r); resultHook(r);
return mResult; return mResult;