GpgFrontend/gpgme
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

cpp: Go with default answer on unknown question by key edit interface

Browse Source 
* lang/cpp/src/editinteractor.cpp (edit_interactor_callback_impl):
Send empty string to edit interface if General Error occurred.
--

A General Error is usually returned by the nextState function of the
concrete EditInteractor subclasses if gpg asks an unexpected question
which isn't handled by the edit interactor's state machine. In this
case, it's usually safe to go with the default answer. This makes the
edit interactors much more robust.

GnuPG-bug-id: 7274
This commit is contained in:
Ingo Klöcker 2024-08-28 16:32:18 +02:00
parent 409e314582
commit 7579c40124
No known key found for this signature in database
GPG Key ID: F5A5D1692277A1E9
1 changed files with 14 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
lang/cpp/src/editinteractor.cpp
View File

@ -167,6 +167,20 @@ public:
} }
error: error:
if (err.code() == GPG_ERR_GENERAL) {
// gpg may have asked an unknown question; try to use the default answer
if (ei->debug) {
std::fprintf(ei->debug, "EditInteractor: action result \"%s\" (go with the default answer)\n", "");
}
if (writeAll(fd, "\n", 1) != 1) {
err = Error::fromSystemError();
if (ei->debug) {
std::fprintf(ei->debug, "EditInteractor: Could not write to fd %d (%s)\n", fd, err.asStdString().c_str());
}
} else {
err = Error();
}
}
if (err || err.isCanceled()) { if (err || err.isCanceled()) {
ei->error = err; ei->error = err;
ei->state = EditInteractor::ErrorState; ei->state = EditInteractor::ErrorState;