GpgFrontend/gpgme
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

json: Ensure that native msging request is string

Browse Source 
* src/gpgme-json.c (native_messaging_repl): Ensure that the
request is NULL terminated.

--
This avoids potential memory leaks and access to unmapped memory
in case the request was not terminated.
Other request functions use es_read_line which gurantees NULL
termination.
This commit is contained in:
Andre Heinecke 2018-07-18 13:06:08 +02:00
parent 82e4b900a9
commit 6d7b4382c3
No known key found for this signature in database
GPG Key ID: 2978E9D40CBABA5C
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/gpgme-json.c
View File

@ -3601,7 +3601,7 @@ native_messaging_repl (void)
} }
/* Read request. */ /* Read request. */
request = xtrymalloc (nrequest); request = xtrymalloc (nrequest + 1);
if (!request) if (!request)
{ {
err = gpg_error_from_syserror (); err = gpg_error_from_syserror ();
@ -3626,6 +3626,7 @@ native_messaging_repl (void)
} }
else /* Process request */ else /* Process request */
{ {
request[n] = '\0'; /* Esnure that request has an end */
if (opt_debug) if (opt_debug)
log_debug ("request='%s'\n", request); log_debug ("request='%s'\n", request);
xfree (response); xfree (response);