From 41d8c7e51a8989be633b9ada124c58a01fae7d54 Mon Sep 17 00:00:00 2001 From: Alon Bar-Lev Date: Wed, 19 Oct 2016 12:04:07 +0300 Subject: [PATCH] tests,python: Atomic directory creation * lang/python/tests/Makefile.am: Use MIDIR_P. * tests/gpg/Makefile.am: Ditto. * tests/gpgsm/Makefile.am: Ditto. -- Solves race in parallel build when mkdir fails if directory exists. Signed-off-by: Alon Bar-Lev - Tweaked the ChangeLog Signed-off-by: Werner Koch --- lang/python/tests/Makefile.am | 2 +- tests/gpg/Makefile.am | 2 +- tests/gpgsm/Makefile.am | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lang/python/tests/Makefile.am b/lang/python/tests/Makefile.am index aa88bdcb..39f532ce 100644 --- a/lang/python/tests/Makefile.am +++ b/lang/python/tests/Makefile.am @@ -89,7 +89,7 @@ clean-local: ./private-keys-v1.d/gpg-sample.stamp: $(private_keys) - test -d ./private-keys-v1.d || mkdir ./private-keys-v1.d + $(MKDIR_P) ./private-keys-v1.d for k in $(private_keys); do \ cp $$k private-keys-v1.d/$${k#$(test_srcdir)/}.key; \ done diff --git a/tests/gpg/Makefile.am b/tests/gpg/Makefile.am index dd33b0a2..c46feb07 100644 --- a/tests/gpg/Makefile.am +++ b/tests/gpg/Makefile.am @@ -93,7 +93,7 @@ export GNUPGHOME := $(abs_builddir) export GPG_AGENT_INFO := ./private-keys-v1.d/gpg-sample.stamp: $(srcdir)/$(private_keys) - test -d ./private-keys-v1.d || mkdir ./private-keys-v1.d + $(MKDIR_P) ./private-keys-v1.d for k in $(private_keys); do \ cp $(srcdir)/$$k private-keys-v1.d/$$k.key; \ done diff --git a/tests/gpgsm/Makefile.am b/tests/gpgsm/Makefile.am index 41645b6c..46d6a9bc 100644 --- a/tests/gpgsm/Makefile.am +++ b/tests/gpgsm/Makefile.am @@ -70,7 +70,7 @@ export GPG_AGENT_INFO := echo faked-system-time 1008241200 >> ./gpgsm.conf ./private-keys-v1.d/$(key_id).key: $(srcdir)/$(key_id) - test -d ./private-keys-v1.d || mkdir ./private-keys-v1.d + $(MKDIR_P) ./private-keys-v1.d cp $(srcdir)/$(key_id) private-keys-v1.d/$(key_id).key ./trustlist.txt: