GpgFrontend/gpgme
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

cpp: Fix use after free in gencardkeyinteractor

Browse Source 
* lang/cpp/src/gpggencardkeyinteractor.cpp
(GpgGenCardKeyInteractor::Private::keysize): Change to string.

--
The value is only required as string so we can save it this
way to avoid the need to convert it for the action command.

GnuPG-Bug-Id: T4094
This commit is contained in:
Andre Heinecke 2018-08-08 09:22:46 +02:00
parent d09d19fa9f
commit 3b78244360
No known key found for this signature in database
GPG Key ID: 2978E9D40CBABA5C
1 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
lang/cpp/src/gpggencardkeyinteractor.cpp
View File

@ -36,12 +36,11 @@ using namespace GpgME;
class GpgGenCardKeyInteractor::Private class GpgGenCardKeyInteractor::Private
{ {
public: public:
Private() : keysize(2048), backup(false) Private() : keysize("2048"), backup(false)
{ {
} }
std::string name, email, backupFileName, expiry, serial; std::string name, email, backupFileName, expiry, serial, keysize;
int keysize;
bool backup; bool backup;
}; };
@ -70,7 +69,7 @@ void GpgGenCardKeyInteractor::setDoBackup(bool value)
void GpgGenCardKeyInteractor::setKeySize(int value) void GpgGenCardKeyInteractor::setKeySize(int value)
{ {
d->keysize = value; d->keysize = std::to_string(value);
} }
void GpgGenCardKeyInteractor::setExpiry(const std::string &timeStr) void GpgGenCardKeyInteractor::setExpiry(const std::string &timeStr)
@ -132,7 +131,7 @@ const char *GpgGenCardKeyInteractor::action(Error &err) const
case SIZE: case SIZE:
case SIZE2: case SIZE2:
case SIZE3: case SIZE3:
return std::to_string(d->keysize).c_str(); return d->keysize.c_str();
case COMMENT: case COMMENT:
return ""; return "";
case SAVE: case SAVE: