From af5979a42b9468ffe0f3ac6de5a77d982c5cf8a0 Mon Sep 17 00:00:00 2001 From: Werner Koch Date: Mon, 23 Jan 2017 16:32:44 +0100 Subject: Fix format string errors and some missing error case initialization. * common/logging.c (do_logv): Remove extra parentheses in comparison. * dirmngr/dns-stuff.c (resolve_addr_libdns): Init RES so that dns_res_close is given a defined value in the error case. * dirmngr/http.c (cookie_read, cookie_write) [HTTP_USE_NTBTLS]: Fix format string char. * dirmngr/ks-engine-hkp.c (ks_hkp_help): Remove duplicate "const". * dirmngr/ks-engine-http.c (ks_http_help): Ditto. * dirmngr/ks-engine-kdns.c (ks_kdns_help): Ditto. * dirmngr/ks-engine-ldap.c (ks_ldap_help): Ditto. * scd/app-p15.c (send_keypairinfo, do_getattr): Fix format string char. * tools/gpgconf-comp.c (gpg_agent_runtime_change): Init PID for the error case. (scdaemon_runtime_change): Ditto. (dirmngr_runtime_change): Ditto. * tools/gpgconf.c (query_swdb): Init VALUE_SIZE_UL. Signed-off-by: Werner Koch --- tools/gpgconf-comp.c | 6 +++--- tools/gpgconf.c | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) (limited to 'tools') diff --git a/tools/gpgconf-comp.c b/tools/gpgconf-comp.c index 300f63da6..a25b5136e 100644 --- a/tools/gpgconf-comp.c +++ b/tools/gpgconf-comp.c @@ -1138,7 +1138,7 @@ gpg_agent_runtime_change (int killflag) gpg_error_t err = 0; const char *pgmname; const char *argv[5]; - pid_t pid; + pid_t pid = (pid_t)(-1); char *abs_homedir = NULL; int i = 0; @@ -1174,7 +1174,7 @@ scdaemon_runtime_change (int killflag) gpg_error_t err = 0; const char *pgmname; const char *argv[9]; - pid_t pid; + pid_t pid = (pid_t)(-1); char *abs_homedir = NULL; int i = 0; @@ -1221,7 +1221,7 @@ dirmngr_runtime_change (int killflag) gpg_error_t err = 0; const char *pgmname; const char *argv[6]; - pid_t pid; + pid_t pid = (pid_t)(-1); char *abs_homedir = NULL; pgmname = gnupg_module_name (GNUPG_MODULE_NAME_CONNECT_AGENT); diff --git a/tools/gpgconf.c b/tools/gpgconf.c index c69b1c3e2..a5ee188ec 100644 --- a/tools/gpgconf.c +++ b/tools/gpgconf.c @@ -280,7 +280,7 @@ query_swdb (estream_t out, const char *name, const char *current_version) gnupg_isotime_t value_date = {0}; char *value_size = NULL; char *value_sha2 = NULL; - unsigned long value_size_ul; + unsigned long value_size_ul = 0; int status, i; -- cgit v1.2.3