From 7bf24e8146116a30c4c9d7b6dbf8bbb27fc35971 Mon Sep 17 00:00:00 2001 From: Werner Koch Date: Thu, 30 Mar 2017 16:01:52 +0200 Subject: gpg: Fix actual leak and possible leaks in the packet parser. * g10/packet.h (struct parse_packet_ctx_s): Change LAST_PKT deom a pointer to its struct. (init_parse_packet): Adjust for LAST_PKT not being a pointer. * g10/parse-packet.c (parse): Ditto. Free the last packet before storing a new one in case of a deep link. (parse_ring_trust): Adjust for LAST_PKT not being a pointer. * g10/free-packet.c (free_packet): Ditto. * g10/t-keydb-get-keyblock.c (do_test): Release keyblock. -- Fixes-commit: afa86809087909a8ba2f9356588bf90cc923529c Signed-off-by: Werner Koch --- g10/build-packet.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'g10/build-packet.c') diff --git a/g10/build-packet.c b/g10/build-packet.c index 1ee57e009..fa2674b2a 100644 --- a/g10/build-packet.c +++ b/g10/build-packet.c @@ -420,7 +420,7 @@ do_user_id( IOBUF out, int ctb, PKT_user_id *uid ) log_assert (ctb_pkttype (ctb) == PKT_USER_ID || ctb_pkttype (ctb) == PKT_ATTRIBUTE); - /* We need to take special care that doe user ID with a length of 0: + /* We need to take special care of a user ID with a length of 0: * Without forcing HDRLEN to 2 in this case an indeterminate length * packet would be written which is not allowed. Note that we are * always called with a CTB indicating an old packet header format, -- cgit v1.2.3