From 3d7dbf16618db4d0dc602daadbde098d4a14b528 Mon Sep 17 00:00:00 2001
From: NIIBE Yutaka <gniibe@fsij.org>
Date: Wed, 14 Sep 2022 11:48:42 +0900
Subject: agent,dirmngr,gpg,scd: Clean up for modern compiler.

* agent/protect.c (agent_get_shadow_info_type): It's a write only
variable, useful for debugging.
* g10/key-check.c (key_check_all_keysigs): Likewise.
* g10/keyedit.c (show_basic_key_info, menu_expire): Likewise.
* scd/app-sc-hsm.c (read_ef_prkd): Likewise.
* dirmngr/crlfetch.c (fetch_next_ksba_cert): Initialize the vars.
* dirmngr/ks-action.c (ks_action_help): Remove unused variables.
* dirmngr/server.c (make_keyserver_item): Likewise.
* dirmngr/validate.c (check_cert_sig): Initialize the variable.
* scd/app-p15.c (select_and_read_record): Likewise.
* tests/gpgscm/scheme.c (scheme_init_new): A function with no args.

--

Signed-off-by: NIIBE Yutaka <gniibe@fsij.org>
---
 dirmngr/crlfetch.c  | 4 ++--
 dirmngr/ks-action.c | 2 --
 dirmngr/server.c    | 1 -
 dirmngr/validate.c  | 3 ++-
 4 files changed, 4 insertions(+), 6 deletions(-)

(limited to 'dirmngr')

diff --git a/dirmngr/crlfetch.c b/dirmngr/crlfetch.c
index 2e0859861..a591a2b5a 100644
--- a/dirmngr/crlfetch.c
+++ b/dirmngr/crlfetch.c
@@ -366,8 +366,8 @@ gpg_error_t
 fetch_next_ksba_cert (cert_fetch_context_t context, ksba_cert_t *r_cert)
 {
   gpg_error_t err;
-  unsigned char *value;
-  size_t valuelen;
+  unsigned char *value = NULL;
+  size_t valuelen = 0;
   ksba_cert_t cert;
 
   *r_cert = NULL;
diff --git a/dirmngr/ks-action.c b/dirmngr/ks-action.c
index 57cf04a7e..45d0b0b13 100644
--- a/dirmngr/ks-action.c
+++ b/dirmngr/ks-action.c
@@ -67,8 +67,6 @@ ks_action_help (ctrl_t ctrl, const char *url)
 {
   gpg_error_t err;
   parsed_uri_t parsed_uri;  /* The broken down URI.  */
-  char *tmpstr;
-  const char *s;
 
   if (!url || !*url)
     {
diff --git a/dirmngr/server.c b/dirmngr/server.c
index 1d9cb7fb4..2928a2596 100644
--- a/dirmngr/server.c
+++ b/dirmngr/server.c
@@ -2126,7 +2126,6 @@ make_keyserver_item (const char *uri, uri_item_t *r_item)
 {
   gpg_error_t err;
   uri_item_t item;
-  const char *s;
   char *tmpstr = NULL;
 
   *r_item = NULL;
diff --git a/dirmngr/validate.c b/dirmngr/validate.c
index 55cf9b1e7..231600ff6 100644
--- a/dirmngr/validate.c
+++ b/dirmngr/validate.c
@@ -950,7 +950,8 @@ check_cert_sig (ksba_cert_t issuer_cert, ksba_cert_t cert)
   int algo;
   ksba_sexp_t p;
   size_t n;
-  gcry_sexp_t s_sig, s_hash, s_pkey;
+  gcry_sexp_t s_sig, s_pkey;
+  gcry_sexp_t s_hash = NULL;
   const char *algo_name; /* hash algorithm name converted to lower case. */
   int digestlen;
   unsigned char *digest;
-- 
cgit v1.2.3