From e03a4a94bb67d4a6c958b37671f83456e203f325 Mon Sep 17 00:00:00 2001 From: Werner Koch Date: Thu, 22 Oct 2015 09:52:51 +0200 Subject: dirmngr: Do not use MAXDNAME. * dirmngr/dns-stuff.c (getsrv): Replace MAXDNAME. * dirmngr/dns-stuff.h (MAXDNAME): Remove. (struct srventry): Use a fixed value instead of MAXDNAME. * dirmngr/http.c (connect_server): Use DIMof instead of MAXDNAME. Malloc a helper array. -- Depending on the order of included headers it might be that we allocate the array with a different size than what we test against in another module. To make it more robust we use the actual known size of checking. A better would be to use a linked list and avoid these large arrays. Signed-off-by: Werner Koch --- dirmngr/dns-stuff.h | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) (limited to 'dirmngr/dns-stuff.h') diff --git a/dirmngr/dns-stuff.h b/dirmngr/dns-stuff.h index 5ffa0178f..13c47df52 100644 --- a/dirmngr/dns-stuff.h +++ b/dirmngr/dns-stuff.h @@ -71,18 +71,13 @@ struct dns_addrinfo_s }; - -#ifndef MAXDNAME -#define MAXDNAME 1025 -#endif - struct srventry { unsigned short priority; unsigned short weight; unsigned short port; int run_count; - char target[MAXDNAME]; + char target[1025]; }; -- cgit v1.2.3