From a95ddffdcd58383cce93677be5e7e11c5c229a98 Mon Sep 17 00:00:00 2001 From: Jakub Jelen Date: Thu, 20 May 2021 10:13:51 +0200 Subject: agent: Avoid memory leaks in error code paths. * agent/command.c (cmd_genkey): Use goto instead of return. * agent/cvt-openpgp.c (convert_from_openpgp_main): Ditto. * agent/genkey.c (agent_ask_new_passphrase): Fix typo to free correct pointer (agent_genkey): Release memory * agent/gpg-agent.c (check_own_socket): Free sockname * agent/protect-tool.c (read_key): Free buf. (agent_askpin): Free passphrase -- Signed-off-by: Jakub Jelen Changed original patch to not add a free before a GPG_ERR_BUG. Signed-off-by: Werner Koch GnuPG-bug-id: 5393 --- common/tlv-builder.c | 1 + 1 file changed, 1 insertion(+) (limited to 'common') diff --git a/common/tlv-builder.c b/common/tlv-builder.c index 3b644ca24..59e2691e0 100644 --- a/common/tlv-builder.c +++ b/common/tlv-builder.c @@ -350,6 +350,7 @@ get_tlv_length (int class, int tag, int constructed, size_t length) (void)constructed; /* Not used, but passed for uniformity of such calls. */ + /* coverity[identical_branches] */ if (tag < 0x1f) { buflen++; -- cgit v1.2.3