From af6c47b2910f394faf582800d60d88e9b4dcf834 Mon Sep 17 00:00:00 2001 From: NIIBE Yutaka Date: Tue, 9 Jul 2024 10:29:44 +0900 Subject: common,kbx,tests: Clean up the PIPE function API. * common/call-gpg.c (_gpg_encrypt, _gpg_decrypt): Simply, use gnupg_create_pipe. * tests/gpgscm/ffi.c (do_inbound_pipe): Likewise. * common/exechelp.h (gnupg_create_inbound_pipe): Use gnupg_fd_t for native pipe descriptor and don't expose other end of pipe. (gnupg_create_outbound_pipe): Ditto. * common/exechelp-posix.c (create_pipe_and_estream): Clean up. (gnupg_create_inbound_pipe): Fail if R_FD or R_FP is NULL. (gnupg_create_outbound_pipe: Ditto. * common/exechelp-w32.c (create_pipe_and_estream): Clean up. (gnupg_create_inbound_pipe): Fail if R_FD or R_FP is NULL. (gnupg_create_outbound_pipe: Ditto. (gnupg_create_pipe): Move the code from original create_pipe_and_estream to call _open_osfhandle. * common/exectool.c (gnupg_exec_tool_stream): Follow the change of API. * kbx/kbx-client-util.c (prepare_data_pipe): Likewise. -- GnuPG-bug-id: 7194 Signed-off-by: NIIBE Yutaka --- common/exectool.c | 24 ++++++++++-------------- 1 file changed, 10 insertions(+), 14 deletions(-) (limited to 'common/exectool.c') diff --git a/common/exectool.c b/common/exectool.c index bb867fbc3..de460084f 100644 --- a/common/exectool.c +++ b/common/exectool.c @@ -331,7 +331,7 @@ gnupg_exec_tool_stream (const char *pgmname, const char *argv[], #else int exceptclose[2]; #endif - int extrapipe[2] = {-1, -1}; + gnupg_fd_t extrapipe; char extrafdbuf[20]; const char *argsave = NULL; int argsaveidx; @@ -387,7 +387,7 @@ gnupg_exec_tool_stream (const char *pgmname, const char *argv[], if (inextra) { - err = gnupg_create_outbound_pipe (extrapipe, &extrafp, 1); + err = gnupg_create_outbound_pipe (&extrapipe, &extrafp, 1); if (err) { log_error ("error creating outbound pipe for extra fp: %s\n", @@ -395,11 +395,7 @@ gnupg_exec_tool_stream (const char *pgmname, const char *argv[], goto leave; } /* Do not close in child. */ -#ifdef HAVE_W32_SYSTEM - exceptclose[i] = (HANDLE)_get_osfhandle (extrapipe[0]); -#else - exceptclose[i] = extrapipe[0]; -#endif + exceptclose[i] = extrapipe; /* Now find the argument marker and replace by the pipe's fd. Yeah, that is an ugly non-thread safe hack but it safes us to create a copy of the array. */ @@ -424,11 +420,7 @@ gnupg_exec_tool_stream (const char *pgmname, const char *argv[], i++; } -#ifdef HAVE_W32_SYSTEM - exceptclose[i] = INVALID_HANDLE_VALUE; -#else - exceptclose[i] = -1; -#endif + exceptclose[i] = GNUPG_INVALID_FD; err = gpgrt_spawn_actions_new (&act); if (err) @@ -447,8 +439,12 @@ gnupg_exec_tool_stream (const char *pgmname, const char *argv[], | GPGRT_PROCESS_STDERR_PIPE), act, &proc); gpgrt_process_get_streams (proc, GPGRT_PROCESS_STREAM_NONBLOCK, input? &infp : NULL, &outfp, &errfp); - if (extrapipe[0] != -1) - close (extrapipe[0]); + if (extrapipe != GNUPG_INVALID_FD) +#ifdef HAVE_W32_SYSTEM + CloseHandle (extrapipe); +#else + close (extrapipe); +#endif if (argsave) argv[argsaveidx] = argsave; if (err) -- cgit v1.2.3