From 999d25d47d45a0f594c84d51c041da0b24d68c5d Mon Sep 17 00:00:00 2001 From: Werner Koch Date: Wed, 8 Jul 2020 14:54:10 +0200 Subject: Do not use the pinentry's qualitybar * agent/genkey.c (agent_ask_new_passphrase): No qualitybar. * g10/call-agent.c (agent_get_passphrase): Ditto. * sm/call-agent.c (gpgsm_agent_ask_passphrase): Ditto. -- The concept of a passphrase quality indicator is anyway questionable because user are smart enough to trick them out and they also tend to limit the actually used entropy. Except for the red/green switching (to show whether constraints are fulfilled) our qualitybar is pretty bad and thus worse than none. Signed-off-by: Werner Koch --- agent/genkey.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'agent/genkey.c') diff --git a/agent/genkey.c b/agent/genkey.c index 6f863db95..970876ba1 100644 --- a/agent/genkey.c +++ b/agent/genkey.c @@ -368,7 +368,7 @@ agent_ask_new_passphrase (ctrl_t ctrl, const char *prompt, } pi->max_length = MAX_PASSPHRASE_LEN + 1; pi->max_tries = 3; - pi->with_qualitybar = 1; + pi->with_qualitybar = 0; pi->with_repeat = 1; pi2->max_length = MAX_PASSPHRASE_LEN + 1; pi2->max_tries = 3; -- cgit v1.2.3