From 638526d37fee0a1febac9d29fab384b913819fc9 Mon Sep 17 00:00:00 2001 From: Werner Koch Date: Thu, 13 Feb 2020 11:45:41 +0100 Subject: agent: Allow signing with card key even without a stub key. * agent/call-scd.c (agent_card_serialno): Allow NULL for R_SERIAL. (struct readkey_status_parm_s): New. (readkey_status_cb): New. (agent_card_readkey): Add optional arg R_KEYREF and change all callers. * agent/findkey.c (key_parms_from_sexp): Allow also a "public-key". * agent/divert-scd.c (ask_for_card): Allow for SHADOW_INFO being NULL. * agent/pksign.c (agent_pksign_do): Fallback to sign with an on-card if there is no stub key yet. Create the stub key. Also fixed a misnaming between s_pkey and s_skey. -- This change allows to create OpenPGP keys directly from a card without first making sure that a stub key exists. It is also the less surprising behaviour. Signed-off-by: Werner Koch --- agent/command.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'agent/command.c') diff --git a/agent/command.c b/agent/command.c index 5f29adbe6..1b07600c3 100644 --- a/agent/command.c +++ b/agent/command.c @@ -1035,7 +1035,7 @@ cmd_readkey (assuan_context_t ctx, char *line) goto leave; } - rc = agent_card_readkey (ctrl, keyid, &pkbuf); + rc = agent_card_readkey (ctrl, keyid, &pkbuf, NULL); if (rc) goto leave; pkbuflen = gcry_sexp_canon_len (pkbuf, 0, NULL, NULL); -- cgit v1.2.3