From ce5a7fb72b599de592a087867768ac1f81fd2989 Mon Sep 17 00:00:00 2001 From: Werner Koch Date: Thu, 9 Jan 2020 12:00:50 +0100 Subject: scd: Use a scdaemon internal key to protect the PIN cache IPC. * agent/call-scd.c (handle_pincache_put): Do not decrypt. (handle_pincache_get): New. (inq_needpin): Call it. * scd/command.c (set_key_for_pincache): New. (pincache_put): Restructure and set key. (pincache_get): Ditto. -- This change does away with encrypting and decrypting the cached PIN in the agent. There is no need for this we can simply cache the cryptogram and let scdaemon decrypt after retrieving it from the agent. This way we do not need to share a key between gpg-agent and scdaemon and further the cached content is invalid after the scdaemon process has been replaced. Signed-off-by: Werner Koch --- agent/cache.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'agent/cache.c') diff --git a/agent/cache.c b/agent/cache.c index 8a6c43a30..c5c67e320 100644 --- a/agent/cache.c +++ b/agent/cache.c @@ -446,7 +446,8 @@ agent_put_cache (ctrl_t ctrl, const char *key, cache_mode_t cache_mode, } -/* Try to find an item in the cache. */ +/* Try to find an item in the cache. Returns NULL if not found or an + * malloced string with the value. */ char * agent_get_cache (ctrl_t ctrl, const char *key, cache_mode_t cache_mode) { -- cgit v1.2.3