From cea6925fa43cacbfd3c20a685740d634b1306aed Mon Sep 17 00:00:00 2001 From: NIIBE Yutaka Date: Wed, 20 May 2020 12:03:07 +0900 Subject: ecc-sos: Fix ECDH. * g10/ecdh.c (pk_ecdh_encrypt_with_shared_point): Fix deallocation. Signed-off-by: NIIBE Yutaka --- g10/ecdh.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/g10/ecdh.c b/g10/ecdh.c index f8080a76a..b4d93be7d 100644 --- a/g10/ecdh.c +++ b/g10/ecdh.c @@ -133,10 +133,7 @@ pk_ecdh_encrypt_with_shared_point (int is_encrypt, gcry_mpi_t shared_mpi, returns X with no prefix of 40, so, nbytes == secret_x_size is allowed. */ if (nbytes < secret_x_size) - { - xfree (secret_x); - return gpg_error (GPG_ERR_BAD_DATA); - } + return gpg_error (GPG_ERR_BAD_DATA); /* Remove the prefix. */ if ((nbytes & 1)) @@ -159,10 +156,7 @@ pk_ecdh_encrypt_with_shared_point (int is_encrypt, gcry_mpi_t shared_mpi, * a KEK. */ if (!gcry_mpi_get_flag (pkey[2], GCRYMPI_FLAG_OPAQUE)) - { - xfree (secret_x); - return gpg_error (GPG_ERR_BUG); - } + return gpg_error (GPG_ERR_BUG); kek_params = gcry_mpi_get_opaque (pkey[2], &nbits); kek_params_size = (nbits+7)/8; -- cgit v1.2.3