From a1f85fdc40e4ebb0bc59fa72104a2297ad427c10 Mon Sep 17 00:00:00 2001 From: Jakub Jelen Date: Tue, 28 May 2024 16:50:59 +0200 Subject: agent: Avoid uninitialized access in GENKEY command on parameter error. * agent/command.c (cmd_genkey): Moved init_membuf to the top. -- Signed-off-by: Jakub Jelen This is part of GnuPG-bug-id: 7129 (cherry picked from commit 379fc5569d604c4a7b5f12b2bbfc4106893c2a9e) --- agent/command.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/agent/command.c b/agent/command.c index 940e017d8..04b024ef6 100644 --- a/agent/command.c +++ b/agent/command.c @@ -876,6 +876,8 @@ cmd_genkey (assuan_context_t ctx, char *line) time_t opt_timestamp; int c; + init_membuf (&outbuf, 512); + if (ctrl->restricted) return leave_cmd (ctx, gpg_error (GPG_ERR_FORBIDDEN)); @@ -928,8 +930,6 @@ cmd_genkey (assuan_context_t ctx, char *line) if (rc) return rc; - init_membuf (&outbuf, 512); - /* If requested, ask for the password to be used for the key. If this is not used the regular Pinentry mechanism is used. */ if (opt_inq_passwd && !no_protection) -- cgit v1.2.3