From 78c4d5d20c422e2cb92c8f6d5c90a297596fa94f Mon Sep 17 00:00:00 2001 From: Werner Koch Date: Wed, 30 Jul 2025 10:25:22 +0200 Subject: gpg: Fix segv in key signing introduced in 2.5.10 * g10/sign.c (mk_notation_policy_etc): Do not free ndmanu if not used. -- GnuPG-bug-id: 7754 Fixes-commit: 11d3a83b04786c74fdbbbcdc99074c75666bd722 --- g10/sign.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/g10/sign.c b/g10/sign.c index b3bda581c..2ba30f09c 100644 --- a/g10/sign.c +++ b/g10/sign.c @@ -125,10 +125,13 @@ mk_notation_policy_etc (ctrl_t ctrl, PKT_signature *sig, xfree (item->altvalue); item->altvalue = NULL; } - /* Restore the original nd and release ndmanu. */ - nd = ndmanu; - ndmanu->next = NULL; - free_notation (ndmanu); + if (with_manu) + { + /* Restore the original nd and release ndmanu. */ + nd = ndmanu; + ndmanu->next = NULL; + free_notation (ndmanu); + } } /* Set policy URL. */ -- cgit v1.2.3