From 479f7bf31ce405e558d844c3eb576b463a8697e5 Mon Sep 17 00:00:00 2001 From: NIIBE Yutaka Date: Tue, 21 May 2019 15:50:28 +0900 Subject: agent: For SSH key, don't put NUL-byte at the end. * agent/command-ssh.c (ssh_key_to_protected_buffer): Update the length by the second call of gcry_sexp_sprint. -- GnuPG-bug-id: 4502 Signed-off-by: NIIBE Yutaka --- agent/command-ssh.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/agent/command-ssh.c b/agent/command-ssh.c index 5f7884b1f..0849a06fc 100644 --- a/agent/command-ssh.c +++ b/agent/command-ssh.c @@ -3007,8 +3007,8 @@ ssh_key_to_protected_buffer (gcry_sexp_t key, const char *passphrase, goto out; } - gcry_sexp_sprint (key, GCRYSEXP_FMT_CANON, buffer_new, buffer_new_n); - /* FIXME: guarantee? */ + buffer_new_n = gcry_sexp_sprint (key, GCRYSEXP_FMT_CANON, + buffer_new, buffer_new_n); if (*passphrase) err = agent_protect (buffer_new, passphrase, buffer, buffer_n, 0, -1); -- cgit v1.2.3