aboutsummaryrefslogtreecommitdiffstats
path: root/g10/getkey.c (unfollow)
Commit message (Collapse)AuthorFilesLines
2014-06-02gpg: Fix bug parsing a zero length user id.Werner Koch1-20/+28
* g10/getkey.c (get_user_id): Do not call xmalloc with 0. * common/xmalloc.c (xmalloc, xcalloc): Take extra precaution not to pass 0 to the arguments. -- The problem did not occur in 1.x because over there the xmalloc makes sure to allocate at least one byte. With 2.x for most calls the xmalloc of Libgcrypt is used and Libgcrypt returns an error insteead of silent allocating a byte. Thus gpg 2.x bailed out with an "Fatal: out of core while allocating 0 bytes". The extra code in xmalloc.c is for more robustness for the other xmalloc calls. (cherry picked from commit 99972bd6e9abea71f270284f49997de5f00208af) Resolved conflicts: g10/getkey.c - ignore whitespace changes.
2013-10-04gpg: Distinguish between missing and cleared key flags.Werner Koch1-1/+7
* include/cipher.h (PUBKEY_USAGE_NONE): New. * g10/getkey.c (parse_key_usage): Set new flag. -- We do not want to use the default capabilities (derived from the algorithm) if any key flags are given in a signature. Thus if key flags are used in any way, the default key capabilities are never used. This allows to create a key with key flags set to all zero so it can't be used. This better reflects common sense. (cherry picked from commit 4bde12206c5bf199dc6e12a74af8da4558ba41bf)
2013-10-04Remove trailing white space from some files.Daniel Kahn Gillmor1-83/+83
--
2009-05-06Fix bug#1034.Werner Koch1-10/+0
Remove dead code.
2009-01-12preparing a releaseWerner Koch1-2/+7
2008-10-20Marked all unused args on non-W32 platforms.Werner Koch1-1/+3
2008-05-09Remove a warning.Werner Koch1-1/+1
2008-05-07--locate-key now returns several keys if they all match.Werner Koch1-9/+59
2008-05-07Add command --locate-key.Werner Koch1-4/+9
Fix auto-key-locate processing of "nodefault".
2008-04-16Test commitDavid Shaw1-2/+2
2008-04-16If there are multiple 0x19 backsigs, take the most recent one. (from 1.4).Werner Koch1-27/+73
add log-file and debug-level to the --gpgconf-list.
2008-04-08Enhanced --auto-key-locate.Werner Koch1-44/+90
2008-04-07Minor cleanups.Werner Koch1-5/+3
Implemented key helper kdns
2008-03-06Comment fixes.Werner Koch1-3/+3
Convey the new envvars when using simple-pwquery.
2007-07-04Changed to GPLv3.Werner Koch1-4/+2
Removed intl/.
2007-03-10From STABLE-BRANCH-1-4David Shaw1-0/+3
* parse-packet.c (parse_signature): It's hex. * getkey.c (merge_selfsigs_subkey): Avoid listing the contents of a backsig when list mode is on. Noted by Timo Schulz.
2007-03-08Fix from 1.4:Werner Koch1-4/+9
* keyedit.c (keyedit_menu): If we modify the keyblock (via fix_keyblock() or collapse_uids()) make sure we reprocess the keyblock so the flags are correct. Noted by Robin H. Johnson. * getkey.c (fixup_uidnode): Properly clear flags that don't apply to us (revoked, expired) so that we can reprocess a uid.
2006-10-20Allow to select X.509 certificates using the keygrip.Werner Koch1-1/+5
2006-10-02Fix for bug 537Werner Koch1-6/+6
2006-06-27Ported patches from 1.4.x Werner Koch1-8/+8
2006-05-23* parse-packet.c (dump_sig_subpkt, parse_signature), build-packet.cDavid Shaw1-7/+7
(build_sig_subpkt_from_sig), getkey.c (fixup_uidnode, merge_selfsigs_main, merge_selfsigs_subkey), keygen.c (keygen_add_key_expire): Fix meaning of key expiration and sig expiration subpackets - zero means "never expire" according to 2440, not "expire instantly".
2006-05-22* getkey.c (get_pubkey_byname), import.c (import_one): Fix key selectionDavid Shaw1-1/+1
problem when auto-key-locate returns a list of keys, not all of which are usable (revoked, expired, etc). Noted by Simon Josefsson.
2006-04-28Merged recent changes from 1.4Werner Koch1-4/+4
2006-04-19Merged with gpg 1.4.3 code. Werner Koch1-290/+676
The gpg part does not yet build.
2006-04-09* getkey.c (parse_auto_key_locate): Fix dupe-removal code.David Shaw1-4/+4
* keyedit.c (menu_backsign): Allow backsigning even if the secret subkey doesn't have a binding signature. * armor.c (radix64_read): Don't report EOF when reading only a pad (=) character. The EOF actually starts after the pad. * gpg.c (main): Make --export, --send-keys, --recv-keys, --refresh-keys, and --fetch-keys follow their arguments from left to right. Suggested by Peter Palfrader.
2006-04-08See ChangeLogWerner Koch1-4/+17
2006-04-01* getkey.c (get_pubkey_byname): Fix missing auto_key_retrieve unlock.David Shaw1-5/+6
Fix strings to not start with a capital letter as per convention.
2006-03-22* getkey.c (parse_auto_key_locate): Silently strip out duplicates ratherDavid Shaw1-5/+10
than causing an error.
2006-03-17* keyserver.c (keyserver_import_cert): Handle the IPGP CERT type forDavid Shaw1-12/+11
both the fingerprint alone, and fingerprint+URL cases. * getkey.c (get_pubkey_byname): Minor cleanup.
2006-03-14* keyserver-internal.h, keyserver.c (keyserver_import_pka): Use theDavid Shaw1-27/+40
same API as the other auto-key-locate fetchers. * getkey.c (get_pubkey_byname): Use the fingerprint of the key that we actually fetched. This helps prevent problems where the key that we fetched doesn't have the same name that we used to fetch it. In the case of CERT and PKA, this is an actual security requirement as the URL might point to a key put in by an attacker. By forcing the use of the fingerprint, we won't use the attacker's key here.
2006-03-14* keyserver-internal.h, keyserver.c (keyserver_spawn, keyserver_work,David Shaw1-4/+4
keyserver_import_cert, keyserver_import_name, keyserver_import_ldap): Pass fingerprint info through.
2006-03-01* getkey.c (parse_auto_key_locate): Error if the user selects "cert" orDavid Shaw1-5/+9
"pka" when those features are disabled. * misc.c (has_invalid_email_chars): Fix some C syntax that broke the compilers on SGI IRIX MIPS and Compaq/DEC OSF/1 Alpha. Noted by Nelson H. F. Beebe.
2006-02-24* keydb.h, getkey.c (release_akl), gpg.c (main): AddDavid Shaw1-8/+24
--no-auto-key-locate. * options.h, gpg.c (main): Keep track of each keyserver registered so we can match on them later. * keyserver-internal.h, keyserver.c (cmp_keyserver_spec, keyserver_match), gpgv.c: New. Find a keyserver that matches ours and return its spec. * getkey.c (get_pubkey_byname): Use it here to get the per-keyserver options from an earlier keyserver.
2006-02-22* options.h, keyserver-internal.h, keyserver.c (keyserver_import_name),David Shaw1-4/+31
getkey.c (free_akl, parse_auto_key_locate, get_pubkey_byname): The obvious next step: allow arbitrary keyservers in the auto-key-locate list.
2006-02-22* options.h, keydb.h, g10.c (main), getkey.c (parse_auto_key_locate):David Shaw1-62/+110
Parse a list of key access methods. (get_pubkey_byname): Walk the list here to try and retrieve keys we don't have locally.
2006-02-21* getkey.c (get_pubkey_byname): Fix minor security problem with PKA whenDavid Shaw1-1/+14
importing at -r time. The URL in the PKA record may point to a key put in by an attacker. Fix is to use the fingerprint from the PKA record as the recipient. This ensures that the PKA record is followed. * keyserver-internal.h, keyserver.c (keyserver_import_pka): Return the fingerprint we requested.
2005-12-23* keyserver.c (keyserver_import_pka): New. Moved fromDavid Shaw1-21/+40
getkey.c:get_pubkey_byname which was getting crowded. * keyserver.c (keyserver_import_cert): Import a key found in DNS via CERT records. Can handle both the PGP (actual key) and IPGP (URL) CERT types. * getkey.c (get_pubkey_byname): Call them both here. * options.h, keyserver.c (parse_keyserver_options): Add "auto-cert-retrieve" option with optional max size argument.
2005-12-23* gpgv.c: Stub.David Shaw1-28/+46
* keyserver-internal.h, keyserver.c (keyserver_spawn, keyserver_work, keygerver_getname): New keyserver_getname function to fetch keys by name. * getkey.c (get_pubkey_byname): Call it here to enable locating keys by full mailbox from a keyserver a la PKA. Try PKA first, though, as it is likely to be faster.
2005-12-20Finished PKA featureWerner Koch1-0/+1
2005-12-19* getkey.c (merge_selfsigs_main): All primary keys can certify.David Shaw1-1/+3
2005-11-10* packet.h: Move some flags to a bitfield. Change all callers.David Shaw1-5/+5
2005-10-27* keyedit.c (menu_addrevoker), getkey.c (finish_lookup): Fix problem withDavid Shaw1-1/+1
adding a cert-only designated revoker. Code was looking for a key with sign ability, and not cert ability. Noted by Timo Schulz.
2005-10-14* keyedit.c (keyedit_menu, menu_backsign): New "backsign" command toDavid Shaw1-1/+4
add 0x19 backsigs to old keys that don't have them. * misc.c (parse_options): Fix build warning. * main.h, keygen.c (make_backsig): Make public.
2005-10-12* options.h, getkey.c (merge_selfsigs_subkey), gpg.c (main), sig-check.cDavid Shaw1-7/+0
(signature_check2): Add --require-backsigs and --no-require-backsigs. Currently defaults to --no-require-backsigs.
2005-10-11* getkey.c (merge_selfsigs_subkey), sig-check.c (signature_check2),David Shaw1-4/+6
keygen.c (make_backsig): Did some backsig interop testing with the PGP folks. All is well, so I'm turning generation of backsigs on for new keys. Checking for backsigs on verification is still off.
2005-08-27* misc.c (openpgp_pk_algo_usage): Default to allowing CERT for signingDavid Shaw1-4/+12
algorithms. * keyedit.c (sign_uids): Don't request a signing key to make a certification. * keygen.c (do_add_key_flags): Force the certify flag on for all primary keys, as the spec requires primary keys must be able to certify (if nothing else, which key is going to issue the user ID signature?) (print_key_flags): Show certify flag. (ask_key_flags, ask_algo): Don't allow setting the C flag for subkeys. * keyid.c (usagestr_from_pk), getkey.c (parse_key_usage): Distinguish between a sign/certify key and a certify-only key.
2005-08-19* options.skel: Remove the surfnet LDAP keyserver from the list ofDavid Shaw1-0/+4
samples since it is being shut down. * getkey.c (classify_user_id): Disable the '.' and '+' search modes since they aren't supported yet.
2005-08-05auto retrieve keys from PKA. Thsi allows to specify an email addressWerner Koch1-12/+48
so that gpg can get the key from DNS. This helps with opportunistic encryption. No integration with the trust modell yet.
2005-07-27Converted all m_free to xfree etc.Werner Koch1-33/+33
2005-06-12* getkey.c (merge_selfsigs_main, merge_selfsigs_subkey): Make sureDavid Shaw1-7/+12
that even after keys may be merged together, we only have one chosen selfsig.