aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* wks: Partly implement draft-koch-openpgp-webkey-service-02.Werner Koch2016-09-294-57/+417
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * tools/gpg-wks.h (WKS_RECEIVE_DRAFT2): New. * tools/wks-receive.c: Include rfc822parse.h. (struct receive_ctx_s): Add fields PARSER, DRAFT_VERSION_2, and MULTIPART_MIXED_SEEN. (decrypt_data): Add --no-options. (verify_signature): Ditto. (new_part): Check for Wks-Draft-Version header. Take care of text parts. (wks_receive): Set Parser and pass a flag value to RESULT_CB. * tools/gpg-wks-client.c (read_confirmation_request): New. (main) <aRead>: Call read_confirmation_request instead of process_confirmation_request. (command_receive_cb): Ditto. Add arg FLAGS.. (decrypt_stream_status_cb, decrypt_stream): New. (command_send): Set header Wks-Draft-Version. * tools/gpg-wks-server.c (struct server_ctx_s): Add field DRAFT_VERSION_2. (sign_stream_status_cb, sign_stream): New. (command_receive_cb): Set draft flag. (send_confirmation_request): Rework to implement protocol draft version 2. * tools/gpg-wks.h (DBG_MIME_VALUE, DBG_PARSER_VALUE): New. (DBG_MIME, DBG_PARSER, DBG_CRYPTO): New. Use instead of a plain opt.debug where useful. * tools/gpg-wks-client.c (debug_flags): Add "mime" and "parser". * tools/gpg-wks-server.c (debug_flags): Ditto. -- If a client supporting the version 2 of the protocol is used, it will tell this the server using a mail header. An old server will ignore that but a recent server will use the new protocol. Next task is to actually write draft-02. There are still a lot of FIXMEs - take care. Signed-off-by: Werner Koch <[email protected]>
* tools: Convey signeddata also to the part_data callback in mime-parser.Werner Koch2016-09-291-20/+38
| | | | | | | | * tools/mime-parser.c (mime_parser_parse): Factor some code out to ... (process_part_data): new. ((mime_parser_parse): Also call process_part_data for signed data. Signed-off-by: Werner Koch <[email protected]>
* tools: Allow retrieval of signed data from mime-maker.Werner Koch2016-09-292-0/+69
| | | | | | | * tools/mime-maker.c (find_part): New. (mime_maker_get_part): New. Signed-off-by: Werner Koch <[email protected]>
* tools: Change mime-maker to write out CR,LF.Werner Koch2016-09-292-34/+107
| | | | | | | | | | | | | | | | | | | | * tools/mime-maker.c (struct part_s): Add field PARTID. (struct mime_maker_context_s): Add field PARTID_COUNTER. (dump_parts): Print part ids. (mime_maker_add_header): Assign PARTID. (mime_maker_add_container): Ditto. (mime_maker_get_partid): New. (write_ct_with_boundary): Remove. (add_header): Strip trailing white spaces. (write_header): Remove trailing spaces trimming. Add arg BOUNDARY. Handle emdedded LFs. (write_gap, write_boundary, write_body): New. (write_tree): Use new functions. -- These changes prepare for forthcoming enhancements. Signed-off-by: Werner Koch <[email protected]>
* tools: Simplify the mime-maker container creation.Werner Koch2016-09-294-40/+34
| | | | | | | | | | | * tools/mime-maker.c (struct part_s): Remove field MEDIATYPE. (release_parts): Ditto. (dump_parts): Print a body line only if tehre is a body. (mime_maker_add_header): Check for body or container. (mime_maker_add_container): Remove arg MEDIATYPE. Change all callers. (mime_maker_end_container): New. Signed-off-by: Werner Koch <[email protected]>
* tools: Give mime parser callbacks access to the rfc822 parser.Werner Koch2016-09-292-0/+24
| | | | | | | | | * tools/mime-parser.c (mime_parser_context_s): Add field MSG. (parse_message_cb): Set it. (mime_parser_rfc822parser): New. * tools/mime-parser.h: Declare rfc822parse_t for the new prototype. Signed-off-by: Werner Koch <[email protected]>
* dirmngr: Fix STARTTLS on LDAP connections.Justus Winter2016-09-291-1/+1
| | | | | | | | * dirmngr/ks-engine-ldap.c (my_ldap_connect): Fix unfortunate typo. -- Courtesy of pkgsrc contributor fhajny. Signed-off-by: Justus Winter <[email protected]>
* gpg: Improve WKD by importing only the requested UID.Werner Koch2016-09-281-5/+32
| | | | | | | | | | | | | * g10/keyserver.c: Include mbox-util.h. (keyserver_import_wkd): Do not use the global import options but employ an import filter. -- We also make sure that an mbox has been passed to keyserver_import_wkd so it may also be called with a complete user id (which is currently not the case). Signed-off-by: Werner Koch <[email protected]>
* gpg: Reject import if an import filter removed all user ids.Werner Koch2016-09-281-0/+27
| | | | | | | * g10/import.c (any_uid_left): New. (import_one): Check that a UID is left. Signed-off-by: Werner Koch <[email protected]>
* gpg: Make import filter data object more flexible.Werner Koch2016-09-282-15/+63
| | | | | | | | | | | | | * g10/main.h (import_filter_t): New. * g10/import.c (struct import_filter_s): Declare struct. (import_keep_uid, import_drop_sig): Replace by ... (import_filter): new. Adjust all users. (cleanup_import_globals): Move code to ... (release_import_filter): new. (save_and_clear_import_filter): New. (restore_import_filter): New. Signed-off-by: Werner Koch <[email protected]>
* gpg: Make sure that internal key import is done with a binary stream.Werner Koch2016-09-281-1/+1
| | | | | | * g10/import.c (import_keys_internal): Open stream in binary mode. Signed-off-by: Werner Koch <[email protected]>
* build: Do not link gpg-connect-agent against npth.Justus Winter2016-09-271-2/+1
| | | | | | * tools/Makefile.am: Do not link gpg-connect-agent against npth. Signed-off-by: Justus Winter <[email protected]>
* build: Fix check for resolver library on macOS.Justus Winter2016-09-271-2/+9
| | | | | | * configure.ac: Check for the mangled name of 'dn_skipname' first. Signed-off-by: Justus Winter <[email protected]>
* common: Correctly handle modules relying on npth.Justus Winter2016-09-271-2/+4
| | | | | | | | * common/Makefile.am (common_sources): Drop 'call-gpg.{c,h}'. (with_npth_sources): New variable. (libcommonpth_a_SOURCES): Use the new variable. Signed-off-by: Justus Winter <[email protected]>
* agent, sm: Set CTX after start_agent.NIIBE Yutaka2016-09-272-12/+31
| | | | | | | | | | | | | | | | * g10/call-agent.c (agent_keytocard): Assign parm.ctx after start_agent. * sm/call-agent.c (gpgsm_agent_pksign, gpgsm_scd_pksign) (gpgsm_agent_readkey, gpgsm_agent_scd_serialno) (gpgsm_agent_scd_keypairinfo, gpgsm_agent_marktrusted) (gpgsm_agent_passwd, gpgsm_agent_get_confirmation) (gpgsm_agent_ask_passphrase, gpgsm_agent_keywrap_key) (gpgsm_agent_export_key): Likewise. -- Reported-by: Rainer Perske GnuPG-bug-id: 2699 Signed-off-by: NIIBE Yutaka <[email protected]>
* dirmngr: Removal of no-libgcrypt.o.NIIBE Yutaka2016-09-271-8/+1
| | | | | | | | | | | | | * dirmngr/Makefile.am (dirmngr_ldap_LDADD): Remove no-libgcrypt.o. -- Thanks to Rainer Perske who located the issue. GnuPG-bug-id: 2698 Signed-off-by: NIIBE Yutaka <[email protected]> This is a fix for the commit: 49829c29e541546084950b8a153067db371d101a
* agent: Allow only specific digest size for ECDSA.NIIBE Yutaka2016-09-271-13/+9
| | | | | | | | | | | | * agent/pksign.c (do_encode_dsa): Fix validation of digest size. -- Thanks to Steven Noonan <[email protected]> who offers patches and a test case. GnuPG-bug-id: 2702 Signed-off-by: NIIBE Yutaka <[email protected]>
* g10: When adding a user id, make sure the keyblock has been prepared.Neal H. Walfield2016-09-222-1/+24
| | | | | | | | | | | | * g10/keyedit.c (keyedit_quick_adduid): Call merge_keys_and_selfsig on KEYBLOCK before adding the user id. * tests/openpgp/quick-key-manipulation.scm: Make sure that the key capabilities don't change when adding a user id. (key-data): New function. -- Signed-off-by: Neal H. Walfield <[email protected]> GnuPG-bug-id: 2697
* tests: Add documentation, make interactive debugging possible.Justus Winter2016-09-202-1/+45
| | | | | | | | | * tests/openpgp/README: Add documentation about debugging and interfacing with GnuPG. * tests/openpgp/run-tests.scm (test::run-sync): Hand stdin to the child so that we can use a repl in the tests. Signed-off-by: Justus Winter <[email protected]>
* tests: Drop the old shell-based tests.Justus Winter2016-09-2040-3337/+1
| | | | | -- Signed-off-by: Justus Winter <[email protected]>
* tests: Port the quick key manipulation test to Scheme.Justus Winter2016-09-202-0/+67
| | | | | | | * tests/openpgp/Makefile.am (XTESTS): Add new test. * tests/openpgp/quick-key-manipulation.scm: New file. Signed-off-by: Justus Winter <[email protected]>
* tests: Remove list of tests from the test runner.Justus Winter2016-09-201-43/+1
| | | | | | * tests/openpgp/run-tests.scm: Drop hardcoded list. Signed-off-by: Justus Winter <[email protected]>
* tests: Reduce runtime of excessive test.Justus Winter2016-09-201-17/+1
| | | | | | | * tests/openpgp/conventional-mdc.scm: Use only two plaintexts when iterating over all cipher algorithms. Signed-off-by: Justus Winter <[email protected]>
* dirmngr: Fix type.Justus Winter2016-09-201-1/+1
| | | | | | * dirmngr/dns-stuff.c (get_dns_cert): Fix type in fallback code. Signed-off-by: Justus Winter <[email protected]>
* dirmngr: Open file CRL's in binary modeAndre Heinecke2016-09-201-1/+1
| | | | | | | | | | * dirmngr/crlcache.c (crl_cache_load): Open file in binary mode. -- This fixes conversion bugs with binary CRL's on Windows. GnuPG-bug-id: issue2448 Signed-off-by: Andre Heinecke <[email protected]>
* doc: Fix a xref usage.NIIBE Yutaka2016-09-201-1/+1
|
* doc: Do not end section names with "."Ineiev2016-09-209-35/+34
|
* doc: Add a few extra coding standard notes.Werner Koch2016-09-201-13/+38
| | | | | | -- Signed-off-by: Werner Koch <[email protected]>
* doc: Fix fix "Not(e) that you can(not) abbreviate".Werner Koch2016-09-206-6/+6
| | | | | | | | | | | -- The commands --help, --version, --dump-options are special in that they can't be abbreciated on the command line. This is to avoid problems with regular options with the same prefix. Fixes-commit: 0a27d8a57c4c990fcada4278a1ce2e6fc9043e9 Signed-off-by: Werner Koch <[email protected]>
* doc: minor fix for @xref.NIIBE Yutaka2016-09-201-1/+1
| | | | * doc/yat2m.c (proc_texi_cmd): Captalize "see" for xref.
* doc: Implement simple '@ref'erences.Justus Winter2016-09-201-0/+1
| | | | | | * doc/yat2m.c (proc_texi_cmd): Handle '@ref'. Signed-off-by: Justus Winter <[email protected]>
* doc: Fix full stops.Ineiev2016-09-207-10/+10
| | | | | | * doc/gpg-agent.texi, doc/gpg.texi, doc/gpgsm.texi, doc/instguide.texi, doc/scdaemon.texi, doc/specify-user-id.texi, doc/tools.texi: Fix.
* doc: Fix spacings.Ineiev2016-09-205-11/+11
| | | | | * doc/debugging.texi, doc/dirmngr.texi, doc/gpg-agent.texi, doc/gpg.texi, doc/tools.texi: Fix.
* doc: Improve markup.Ineiev2016-09-207-42/+43
| | | | | | * doc/gpg-agent.texi, doc/gpg.texi, doc/gpgsm.texi, doc/howto-create-a-server-cert.texi, doc/scdaemon.texi, doc/specify-user-id.texi, doc/tools.texi: Fix.
* doc: Replace rfc0123 with RFC-0123.Ineiev2016-09-203-4/+4
| | | | * doc/gpg.texi, doc/gpgsm.texi, doc/specify-user-id.texi: Fix.
* doc: Add missing description of datafile.Ineiev2016-09-201-3/+3
| | | | * doc/gpg.texi: Fix.
* doc: Replace UTF8 with UTF-8.Ineiev2016-09-201-2/+2
| | | | * doc/gpg.texi: Fix.
* doc: Fix mistakes.Ineiev2016-09-206-18/+17
| | | | | | * doc/dirmngr.texi, doc/gpg.texi, doc/gpgsm.texi, doc/howto-create-a-server-cert.texi, doc/scdaemon.texi, doc/tools.texi: Fix.
* doc: Eliminate inconsistent UK English.Ineiev2016-09-204-7/+7
| | | | | * doc/dirmngr.texi, doc/gpg-agent.texi, doc/scdaemon.texi, doc/tools.texi: Fix.
* doc: Use the right reference commands.Ineiev2016-09-205-12/+11
| | | | | * doc/debugging.texi, doc/gpg-agent.texi, doc/gpg.texi, doc/gpgsm.texi, doc/tools.texi: Fix.
* doc: Fix "Not(e) that you can(not) abbreviate".Ineiev2016-09-206-8/+8
| | | | | * doc/dirmngr.texi, doc/gpg-agent.texi, doc/gpg.texi, doc/gpgsm.texi, doc/scdaemon.texi, doc/tools.texi: Fix.
* doc: Fix typos.Ineiev2016-09-2011-59/+59
| | | | | | | * doc/debugging.texi, doc/dirmngr.texi, doc/glossary.texi * doc/gpg-agent.texi, doc/gpg.texi, doc/gpgsm.texi * doc/instguide.texi, doc/opt-homedir.texi, doc/scdaemon.texi * doc/specify-user-id.texi, doc/tools.texi: Fix.
* doc: Fix Martin Hellman's name.Ineiev2016-09-201-1/+1
| | | | * doc/contrib.texi: Fix.
* tests: Refine the repl function.Justus Winter2016-09-191-21/+21
| | | | | | | | | | | | | | * tests/gpgscm/repl.scm (repl): Add an argument 'environment'. (interactive-repl): Add an optional argument 'environment'. -- With this change, we can drop (interactive-repl (current-environment)) anywhere into the code and do some interactive debugging. Signed-off-by: Justus Winter <[email protected]>
* tests: Implement interpreter shutdown using exceptions.Justus Winter2016-09-192-1/+23
| | | | | | | | | | | * tests/gpgscm/ffi.c (ffi_init): Rename 'exit' to '_exit'. * tests/gpgscm/ffi.scm (*interpreter-exit*): New variable. (throw): New function. (exit): New function. -- This allows a proper cleanup of resources. Signed-off-by: Justus Winter <[email protected]>
* tests: Correctly handle exceptions in resource handling macros.Justus Winter2016-09-191-4/+13
| | | | | | | | | | * tests/gpgscm/tests.scm (letfd): Correctly release resources when an exception is thrown. (with-working-directory): Likewise. (with-temporary-working-directory): Likewise. (lettmp): Likewise. Signed-off-by: Justus Winter <[email protected]>
* tests: Refine exception handling.Justus Winter2016-09-193-7/+7
| | | | | | | | | | * tests/gpgscm/init.scm (catch): Bind all arguments to '*error*' in the error handler, update and fix comment. (*error-hook*): Revert to original definition. * tests/gpgscm/tests.scm (tr:do): Adapt accordingly. * tests/openpgp/issue2419.scm: Likewise. Signed-off-by: Justus Winter <[email protected]>
* tests: Use descriptive temporary file names.Justus Winter2016-09-194-4/+21
| | | | | | | | | | | | * tests/gpgscm/ffi.c (do_get_isotime): New function. (ffi_init): Add parameter 'scriptname', bind new function and scriptname. * tests/gpgscm/ffi.h (ffi_init): Update prototype. * tests/gpgscm/main.c (main): Hand in the script name. * tests/gpgscm/tests.scm (mkdtemp): Use current time and script name for the names of temporary directories. Signed-off-by: Justus Winter <[email protected]>
* gpg: Fix regression in fingerprint printing.Werner Koch2016-09-191-1/+1
| | | | | | | | | | * g10/keylist.c (list_keyblock_print): Do not depend calling print_fingerprint on opt.keyid_format. -- Regression-due-to: d757009a24eb856770fc3a3729e2f21f54d2a618 Debian-bug-id: 838153 Signed-off-by: Werner Koch <[email protected]>
* dirmngr: Silence diagnostics about starting housekeeping.Werner Koch2016-09-191-2/+2
| | | | | | | * dirmngr/dirmngr.c (housekeeping_thread): Print info only in very verbose mode. Signed-off-by: Werner Koch <[email protected]>