aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDaniel Kahn Gillmor <[email protected]>2019-07-15 20:24:35 +0000
committerDaniel Kahn Gillmor <[email protected]>2019-07-20 18:16:21 +0000
commitab76d6483741ba15c1ad1233470604153528fba0 (patch)
tree84f234ffed98de0cb579f00ad5c22bb1822b1acd
parentfix spelling (diff)
downloadgnupg-ab76d6483741ba15c1ad1233470604153528fba0.tar.gz
gnupg-ab76d6483741ba15c1ad1233470604153528fba0.zip
gpg: drop import-clean from default keyserver import options
* g10/gpg.c (main): drop IMPORT_CLEAN from the default opt.keyserver_options.import_options * doc/gpg.texi: reflect this change in the documentation Given that SELF_SIGS_ONLY is already set, it's not clear what additional benefit IMPORT_CLEAN provides. Furthermore, IMPORT_CLEAN means that receiving an OpenPGP certificate from a keyserver will potentially delete data that is otherwise held in the local keyring, which is surprising to users who expect retrieval from the keyservers to be purely additive. GnuPG-Bug-Id: 4628 Signed-off-by: Daniel Kahn Gillmor <[email protected]> Gbp-Pq: Name gpg-drop-import-clean-from-default-keyserver-import-optio.patch
-rw-r--r--doc/gpg.texi2
-rw-r--r--g10/gpg.c3
2 files changed, 2 insertions, 3 deletions
diff --git a/doc/gpg.texi b/doc/gpg.texi
index 8a88b11d7..3a5214bc3 100644
--- a/doc/gpg.texi
+++ b/doc/gpg.texi
@@ -1933,7 +1933,7 @@ are available for all keyserver types, some common options are:
@end table
-The default list of options is: "self-sigs-only, import-clean,
+The default list of options is: "self-sigs-only,
repair-keys, repair-pks-subkey-bug, export-attributes,
honor-pka-record".
diff --git a/g10/gpg.c b/g10/gpg.c
index 2c784d491..60304878e 100644
--- a/g10/gpg.c
+++ b/g10/gpg.c
@@ -2376,8 +2376,7 @@ main (int argc, char **argv)
opt.export_options = EXPORT_ATTRIBUTES;
opt.keyserver_options.import_options = (IMPORT_REPAIR_KEYS
| IMPORT_REPAIR_PKS_SUBKEY_BUG
- | IMPORT_SELF_SIGS_ONLY
- | IMPORT_CLEAN);
+ | IMPORT_SELF_SIGS_ONLY);
opt.keyserver_options.export_options = EXPORT_ATTRIBUTES;
opt.keyserver_options.options = KEYSERVER_HONOR_PKA_RECORD;
opt.verify_options = (LIST_SHOW_UID_VALIDITY