diff options
Diffstat (limited to 'src/core/function/basic')
-rw-r--r-- | src/core/function/basic/ChannelObject.cpp | 2 | ||||
-rw-r--r-- | src/core/function/basic/GpgFunctionObject.cpp | 17 | ||||
-rw-r--r-- | src/core/function/basic/SingletonStorage.cpp | 26 | ||||
-rw-r--r-- | src/core/function/basic/SingletonStorageCollection.cpp | 15 |
4 files changed, 23 insertions, 37 deletions
diff --git a/src/core/function/basic/ChannelObject.cpp b/src/core/function/basic/ChannelObject.cpp index 18449ddb..1d9d60b5 100644 --- a/src/core/function/basic/ChannelObject.cpp +++ b/src/core/function/basic/ChannelObject.cpp @@ -39,7 +39,7 @@ ChannelObject::ChannelObject(int channel, QString type) #ifdef DEBUG ChannelObject::~ChannelObject() noexcept { - // using iostream instead of spdlog bacause at this time spdlog may have + // using iostream instead of log bacause at this time log object may have // already been destroyed. QTextStream(stdout) << "releasing channel object: " << this->type_ << Qt::endl; diff --git a/src/core/function/basic/GpgFunctionObject.cpp b/src/core/function/basic/GpgFunctionObject.cpp index e9e444f1..2e531c15 100644 --- a/src/core/function/basic/GpgFunctionObject.cpp +++ b/src/core/function/basic/GpgFunctionObject.cpp @@ -44,8 +44,8 @@ std::mutex g_function_object_mutex_map_lock; std::map<size_t, FunctionObjectTypeLockInfo> g_function_object_mutex_map; namespace GpgFrontend { -auto GetGlobalFunctionObjectChannelLock(const std::type_info& type, int channel) - -> std::mutex& { +auto GetGlobalFunctionObjectChannelLock(const std::type_info& type, + int channel) -> std::mutex& { std::lock_guard<std::mutex> lock_guard(g_function_object_mutex_map_lock); auto& channel_map = g_function_object_mutex_map[type.hash_code()]; return channel_map.channel_lock_map[channel]; @@ -64,24 +64,17 @@ auto GetGlobalFunctionObjectTypeLock(const std::type_info& type) * @param channel * @return T& */ -auto GetChannelObjectInstance(const std::type_info& type, int channel) - -> ChannelObject* { - GF_DEFAULT_LOG_TRACE("try to get instance of type: {} at channel: {}", - type.name(), channel); - +auto GetChannelObjectInstance(const std::type_info& type, + int channel) -> ChannelObject* { // lock this channel std::lock_guard<std::mutex> guard( GetGlobalFunctionObjectChannelLock(type, channel)); auto* p_storage = SingletonStorageCollection::GetInstance(false)->GetSingletonStorage(type); - GF_DEFAULT_LOG_TRACE("get singleton storage result, p_storage: {}", - static_cast<void*>(p_storage)); auto* p_pbj = static_cast<ChannelObject*>(p_storage->FindObjectInChannel(channel)); - GF_DEFAULT_LOG_TRACE("find channel object result, channel {}, p_pbj: {}", - channel, static_cast<void*>(p_pbj)); return p_pbj; } @@ -95,8 +88,6 @@ auto CreateChannelObjectInstance(const std::type_info& type, int channel, auto* p_storage = SingletonStorageCollection::GetInstance(false)->GetSingletonStorage(type); - GF_DEFAULT_LOG_TRACE("create channel object, channel {}, type: {}", channel, - type.name()); // do create object of this channel return p_storage->SetObjectInChannel(channel, std::move(channel_object)); diff --git a/src/core/function/basic/SingletonStorage.cpp b/src/core/function/basic/SingletonStorage.cpp index eab71e0f..fd583820 100644 --- a/src/core/function/basic/SingletonStorage.cpp +++ b/src/core/function/basic/SingletonStorage.cpp @@ -53,8 +53,7 @@ class SingletonStorage::Impl { std::shared_lock<std::shared_mutex> lock(instances_mutex_); ins_it = instances_map_.find(channel); if (ins_it == instances_map_.end()) { - GF_DEFAULT_LOG_TRACE("cannot find channel object, channel: {}", - channel); + qCDebug(core, "cannot find channel object, channel: %d", channel); return nullptr; } return ins_it->second.get(); @@ -72,14 +71,14 @@ class SingletonStorage::Impl { auto SetObjectInChannel(int channel, ChannelObjectPtr p_obj) -> GpgFrontend::ChannelObject* { - GF_DEFAULT_LOG_TRACE( - "set channel object, type: {} in channel: {}, address: {}", - typeid(p_obj.get()).name(), channel, static_cast<void*>(p_obj.get())); + qCDebug(core, "set channel object, type: %s in channel: %d, address: %p", + typeid(p_obj.get()).name(), channel, + static_cast<void*>(p_obj.get())); assert(p_obj != nullptr); if (p_obj == nullptr) { - GF_DEFAULT_LOG_ERROR( - "cannot set a nullptr as a channel obejct of channel: {}", channel); + qCWarning(core, "cannot set a nullptr as a channel object of channel: %d", + channel); return nullptr; } @@ -87,17 +86,16 @@ class SingletonStorage::Impl { auto* raw_obj = p_obj.get(); { - GF_DEFAULT_LOG_TRACE( - "register channel object to instances map, " - "channel: {}, address: {}", - channel, static_cast<void*>(p_obj.get())); + qCDebug(core, + "register channel object to instances map, " + "channel: %d, address: %p", + channel, static_cast<void*>(p_obj.get())); std::unique_lock<std::shared_mutex> lock(instances_mutex_); instances_map_[channel] = std::move(p_obj); } - GF_DEFAULT_LOG_TRACE( - "set channel: {} success, current channel object address: {}", channel, - static_cast<void*>(raw_obj)); + qCDebug(core, "set channel: %d success, current channel object address: %p", + channel, static_cast<void*>(raw_obj)); return raw_obj; } diff --git a/src/core/function/basic/SingletonStorageCollection.cpp b/src/core/function/basic/SingletonStorageCollection.cpp index c22b5242..1eee087a 100644 --- a/src/core/function/basic/SingletonStorageCollection.cpp +++ b/src/core/function/basic/SingletonStorageCollection.cpp @@ -49,9 +49,9 @@ class SingletonStorageCollection::Impl { static auto GetInstance(bool force_refresh) -> SingletonStorageCollection* { if (force_refresh || global_instance == nullptr) { global_instance = SecureCreateUniqueObject<SingletonStorageCollection>(); - GF_DEFAULT_LOG_TRACE( - "a new global singleton storage collection created, address: {}", - static_cast<void*>(global_instance.get())); + qCDebug(core, + "a new global singleton storage collection created, address: %p", + static_cast<void*>(global_instance.get())); } return global_instance.get(); } @@ -80,10 +80,6 @@ class SingletonStorageCollection::Impl { } if (ins_it == storages_map_.end()) { auto storage = SecureCreateUniqueObject<SingletonStorage>(); - GF_DEFAULT_LOG_TRACE( - "hash: {} created, singleton storage address: {} type_name: {}", - hash, static_cast<void*>(storage.get()), type_id.name()); - { std::unique_lock<std::shared_mutex> lock(storages_mutex_); storages_map_.insert({hash, std::move(storage)}); @@ -110,8 +106,9 @@ auto GpgFrontend::SingletonStorageCollection::GetInstance(bool force_refresh) } void SingletonStorageCollection::Destroy() { - GF_DEFAULT_LOG_TRACE( - "global singleton storage collection is about to destroy, address: {}", + qCDebug( + core, + "global singleton storage collection is about to destroy, address: %p", static_cast<void*>(global_instance.get())); return SingletonStorageCollection::Impl::Destroy(); } |