aboutsummaryrefslogtreecommitdiffstats
path: root/src/ui/thread/KeyServerSearchTask.cpp
diff options
context:
space:
mode:
authorsaturneric <[email protected]>2024-01-16 03:49:50 +0000
committersaturneric <[email protected]>2024-01-16 03:49:50 +0000
commit4994f4eaa1211d402b791660ad6221154a4c2405 (patch)
treec3f0cdc0008849de79c6bd8030c0c65c5d02f9f3 /src/ui/thread/KeyServerSearchTask.cpp
parentfix: slove a heap-use-after-free problem (diff)
downloadGpgFrontend-4994f4eaa1211d402b791660ad6221154a4c2405.tar.gz
GpgFrontend-4994f4eaa1211d402b791660ad6221154a4c2405.zip
fix: make task and threading system safer
Diffstat (limited to '')
-rw-r--r--src/ui/thread/KeyServerSearchTask.cpp7
1 files changed, 3 insertions, 4 deletions
diff --git a/src/ui/thread/KeyServerSearchTask.cpp b/src/ui/thread/KeyServerSearchTask.cpp
index b0e253f0..2f05b774 100644
--- a/src/ui/thread/KeyServerSearchTask.cpp
+++ b/src/ui/thread/KeyServerSearchTask.cpp
@@ -28,8 +28,6 @@
#include "ui/thread/KeyServerSearchTask.h"
-#include <utility>
-
GpgFrontend::UI::KeyServerSearchTask::KeyServerSearchTask(QString keyserver_url,
QString search_string)
: Task("key_server_search_task"),
@@ -39,15 +37,16 @@ GpgFrontend::UI::KeyServerSearchTask::KeyServerSearchTask(QString keyserver_url,
HoldOnLifeCycle(true);
}
-void GpgFrontend::UI::KeyServerSearchTask::Run() {
+auto GpgFrontend::UI::KeyServerSearchTask::Run() -> int {
QUrl url_from_remote = keyserver_url_ +
"/pks/lookup?search=" + search_string_ +
"&op=index&options=mr";
reply_ = manager_->get(QNetworkRequest(url_from_remote));
-
connect(reply_, &QNetworkReply::finished, this,
&KeyServerSearchTask::dealing_reply_from_server);
+
+ return 0;
}
void GpgFrontend::UI::KeyServerSearchTask::dealing_reply_from_server() {