<refactor>(ui): tidy up codes and add comments.

1. tidy up keypair_details.

1 files changed, 29 insertions, 28 deletions

diff --git a/src/ui/keypair_details/KeyNewUIDDialog.cpp b/src/ui/keypair_details/KeyNewUIDDialog.cpp
index a4f2bd74..6779ecfb 100644
--- a/src/ui/keypair_details/KeyNewUIDDialog.cpp
+++ b/src/ui/keypair_details/KeyNewUIDDialog.cpp
@@ -30,62 +30,63 @@
 
 namespace GpgFrontend::UI {
 KeyNewUIDDialog::KeyNewUIDDialog(const KeyId& key_id, QWidget* parent)
-    : QDialog(parent), mKey(GpgKeyGetter::GetInstance().GetKey(key_id)) {
-  name = new QLineEdit();
-  name->setMinimumWidth(240);
-  email = new QLineEdit();
-  email->setMinimumWidth(240);
-  comment = new QLineEdit();
-  comment->setMinimumWidth(240);
-  createButton = new QPushButton("Create");
-  errorLabel = new QLabel();
+    : QDialog(parent), m_key_(GpgKeyGetter::GetInstance().GetKey(key_id)) {
+  name_ = new QLineEdit();
+  name_->setMinimumWidth(240);
+  email_ = new QLineEdit();
+  email_->setMinimumWidth(240);
+  comment_ = new QLineEdit();
+  comment_->setMinimumWidth(240);
+  create_button_ = new QPushButton("Create");
+  error_label_ = new QLabel();
 
   auto gridLayout = new QGridLayout();
   gridLayout->addWidget(new QLabel(_("Name")), 0, 0);
   gridLayout->addWidget(new QLabel(_("Email")), 1, 0);
   gridLayout->addWidget(new QLabel(_("Comment")), 2, 0);
 
-  gridLayout->addWidget(name, 0, 1);
-  gridLayout->addWidget(email, 1, 1);
-  gridLayout->addWidget(comment, 2, 1);
+  gridLayout->addWidget(name_, 0, 1);
+  gridLayout->addWidget(email_, 1, 1);
+  gridLayout->addWidget(comment_, 2, 1);
 
-  gridLayout->addWidget(createButton, 3, 0, 1, 2);
+  gridLayout->addWidget(create_button_, 3, 0, 1, 2);
   gridLayout->addWidget(
       new QLabel(_("Notice: The New UID Created will be set as Primary.")), 4,
       0, 1, 2);
-  gridLayout->addWidget(errorLabel, 5, 0, 1, 2);
+  gridLayout->addWidget(error_label_, 5, 0, 1, 2);
 
-  connect(createButton, SIGNAL(clicked(bool)), this, SLOT(slotCreateNewUID()));
+  connect(create_button_, SIGNAL(clicked(bool)), this,
+          SLOT(slot_create_new_uid()));
 
   this->setLayout(gridLayout);
   this->setWindowTitle(_("Create New UID"));
   this->setAttribute(Qt::WA_DeleteOnClose, true);
   this->setModal(true);
 
-  connect(this, SIGNAL(signalUIDCreated()), SignalStation::GetInstance(),
+  connect(this, SIGNAL(SignalUIDCreated()), SignalStation::GetInstance(),
           SIGNAL(KeyDatabaseRefresh()));
 }
 
-void KeyNewUIDDialog::slotCreateNewUID() {
+void KeyNewUIDDialog::slot_create_new_uid() {
   std::stringstream error_stream;
 
   /**
    * check for errors in keygen dialog input
    */
-  if ((name->text()).size() < 5) {
+  if ((name_->text()).size() < 5) {
     error_stream << "  " << _("Name must contain at least five characters.")
                  << std::endl;
   }
-  if (email->text().isEmpty() || !check_email_address(email->text())) {
+  if (email_->text().isEmpty() || !check_email_address(email_->text())) {
     error_stream << "  " << _("Please give a email address.") << std::endl;
   }
   auto error_string = error_stream.str();
   if (error_string.empty()) {
-    if (UIDOperator::GetInstance().AddUID(mKey, name->text().toStdString(),
-                                          comment->text().toStdString(),
-                                          email->text().toStdString())) {
+    if (UIDOperator::GetInstance().AddUID(m_key_, name_->text().toStdString(),
+                                          comment_->text().toStdString(),
+                                          email_->text().toStdString())) {
       emit finished(1);
-      emit signalUIDCreated();
+      emit SignalUIDCreated();
     } else
       emit finished(-1);
 
@@ -93,17 +94,17 @@ void KeyNewUIDDialog::slotCreateNewUID() {
     /**
      * create error message
      */
-    errorLabel->setAutoFillBackground(true);
-    QPalette error = errorLabel->palette();
+    error_label_->setAutoFillBackground(true);
+    QPalette error = error_label_->palette();
     error.setColor(QPalette::Window, "#ff8080");
-    errorLabel->setPalette(error);
-    errorLabel->setText(error_string.c_str());
+    error_label_->setPalette(error);
+    error_label_->setText(error_string.c_str());
 
     this->show();
   }
 }
 
 bool KeyNewUIDDialog::check_email_address(const QString& str) {
-  return re_email.match(str).hasMatch();
+  return re_email_.match(str).hasMatch();
 }
 }  // namespace GpgFrontend::UI