fix: improve module

5 files changed, 13 insertions, 7 deletions

diff --git a/src/module/CMakeLists.txt b/src/module/CMakeLists.txt
index 683386b2..b12e207a 100644
--- a/src/module/CMakeLists.txt
+++ b/src/module/CMakeLists.txt
@@ -32,7 +32,10 @@ aux_source_directory(sdk MODULE_SDK_SOURCE)
 add_library(gpgfrontend_module_sdk SHARED ${MODULE_SDK_SOURCE})
 set(_export_file_sdk "${CMAKE_CURRENT_SOURCE_DIR}/sdk/GpgFrontendModuleSDKExport.h")
 generate_export_header(gpgfrontend_module_sdk EXPORT_FILE_NAME "${_export_file_sdk}")
-target_include_directories(gpgfrontend_module_sdk PUBLIC sdk)
+target_include_directories(gpgfrontend_module_sdk PUBLIC 
+        sdk 
+        ${CMAKE_CURRENT_BINARY_DIR}/gpgfrontend_module_sdk_autogen/include
+        ${CMAKE_SOURCE_DIR}/third_party/spdlog/include)
 
 # link module system
 target_link_libraries(gpgfrontend_module_sdk
@@ -66,9 +69,6 @@ target_include_directories(gpgfrontend_module PUBLIC
         ${CMAKE_CURRENT_BINARY_DIR}/gpgfrontend_module_autogen/include
         ${CMAKE_SOURCE_DIR}/third_party/spdlog/include)
 
-target_link_libraries(gpgfrontend_module PRIVATE
-        gpgfrontend_core gpgfrontend_ui)
-
 # link gpgfrontend_module_sdk
 target_link_libraries(gpgfrontend_module PRIVATE gpgfrontend_module_sdk)
 
diff --git a/src/module/integrated/version_checking_module/VersionCheckTask.h b/src/module/integrated/version_checking_module/VersionCheckTask.h
index 1fe39973..253914ba 100644
--- a/src/module/integrated/version_checking_module/VersionCheckTask.h
+++ b/src/module/integrated/version_checking_module/VersionCheckTask.h
@@ -49,7 +49,7 @@ class VersionCheckTask : public Thread::Task {
    * @brief Construct a new Version Check Thread object
    *
    */
-  explicit VersionCheckTask();
+  VersionCheckTask();
 
  signals:
 
diff --git a/src/module/integrated/version_checking_module/VersionCheckingModule.cpp b/src/module/integrated/version_checking_module/VersionCheckingModule.cpp
index 64fee5dc..7207d734 100644
--- a/src/module/integrated/version_checking_module/VersionCheckingModule.cpp
+++ b/src/module/integrated/version_checking_module/VersionCheckingModule.cpp
@@ -39,7 +39,7 @@ VersionCheckingModule::VersionCheckingModule()
 
 bool VersionCheckingModule::Register() {
   SPDLOG_INFO("version checking module registering");
-  listenEvent("APPLICATION_STARTED");
+  listenEvent("APPLICATION_LOADED");
   return true;
 }
 
diff --git a/src/module/sdk/Basic.h b/src/module/sdk/Basic.h
index 0702632a..0246da09 100644
--- a/src/module/sdk/Basic.h
+++ b/src/module/sdk/Basic.h
@@ -26,4 +26,10 @@
  *
  */
 
-#pragma once
\ No newline at end of file
+#pragma once
+
+namespace GpgFrontend::Module::SDK {
+
+
+
+}
\ No newline at end of file
diff --git a/src/module/system/GlobalModuleContext.cpp b/src/module/system/GlobalModuleContext.cpp
deleted file mode 100644
index e69de29b..00000000
--- a/src/module/system/GlobalModuleContext.cpp
+++ /dev/null