diff options
| author | saturneric <[email protected]> | 2024-08-05 15:29:04 +0000 |
|---|---|---|
| committer | saturneric <[email protected]> | 2024-08-05 15:29:04 +0000 |
| commit | 512c2198507bcfa4367e39163edf8b626a3008a9 (patch) | |
| tree | 7039371d43fe1f9989856d504f7a42c3b40ea6eb /.github/workflows/release.yml | |
| parent | fix: addressing some of the significant deficiencies identified (diff) | |
| download | GpgFrontend-512c2198507bcfa4367e39163edf8b626a3008a9.tar.gz GpgFrontend-512c2198507bcfa4367e39163edf8b626a3008a9.zip | |
fix: remove mimalloc from source
Too bad, under Flatpak or even under Windows, this library can cause the program to crash. The reason for this is that there are some places that do not override the memory allocation method, but this does not guarantee that the mimalloc library will be loaded first in some environments (especially Flatpak) so I think it would be better to let the user install it themselves rather than include this library. Then override all mallocs as needed, which is easy to do. Sacrificing some of the security of the default state for the stability of the program feels necessary to me.
Diffstat (limited to '')
| -rw-r--r-- | .github/workflows/release.yml | 20 |
1 files changed, 0 insertions, 20 deletions
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 47bf1f5d..e6542d4d 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -164,26 +164,6 @@ jobs: make install if: matrix.os == 'windows-2019' - - name: Build mimalloc (Linux) - run: | - git clone --depth 1 --branch v2.1.7 https://github.com/microsoft/mimalloc.git ${{github.workspace}}/third_party/mimalloc - cd ${{github.workspace}}/third_party/mimalloc - mkdir build && cd build - cmake -G Ninja -DMI_SECURE=ON .. - ninja - sudo ninja install - if: matrix.os == 'ubuntu-20.04' - - - name: Build mimalloc (Windows) - shell: msys2 {0} - run: | - git clone --depth 1 --branch v2.1.7 https://github.com/microsoft/mimalloc.git ${{github.workspace}}/third_party/mimalloc - cd ${{github.workspace}}/third_party/mimalloc - mkdir build && cd build - cmake -G Ninja -DMI_SECURE=ON -DCMAKE_INSTALL_PREFIX=$MSYSTEM_PREFIX .. && ninja - ninja install - if: matrix.os == 'windows-2019' - - name: Build googletest (Linux) run: | git clone --depth 1 --branch v1.15.0 https://github.com/google/googletest.git ${{github.workspace}}/third_party/googletest |